git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 10/16] Do not read .git/info/exclude if there is no repository

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Mar 11, 2010, 13:22 UTC
Message-ID
<1268313754-28179-11-git-send-email-pclouds@gmail.com>
In-Reply-To
<1268313754-28179-1-git-send-email-pclouds@gmail.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 dir.c           |    8 +++++---
 t/t7002-grep.sh |   24 ++++++++++++++++++++++++
 2 files changed, 29 insertions(+), 3 deletions(-)
diff --git a/dir.c b/dir.c
index 133c333..fee19fe 100644
--- a/dir.c
+++ b/dir.c
@@ -1024,9 +1024,11 @@ void setup_standard_excludes(struct dir_struct *dir)
 	const char *path;
 
 	dir->exclude_per_dir = ".gitignore";
-	path = git_path("info/exclude");
-	if (!access(path, R_OK))
-		add_excludes_from_file(dir, path);
+	if (!startup_info || startup_info->have_repository) {
+		path = git_path("info/exclude");
+		if (!access(path, R_OK))
+			add_excludes_from_file(dir, path);
+	}
 	if (excludes_file && !access(excludes_file, R_OK))
 		add_excludes_from_file(dir, excludes_file);
 }
diff --git a/t/t7002-grep.sh b/t/t7002-grep.sh
index e249c3e..06ec4cb 100755
--- a/t/t7002-grep.sh
+++ b/t/t7002-grep.sh
@@ -527,4 +527,28 @@ test_expect_success 'grep -e -- -- path' '
 	test_cmp expected actual
 '
 
+test_expect_success 'Setup fake .git' '
+	cd t &&
+	GIT_CEILING_DIRECTORIES="`pwd`" &&
+	export GIT_CEILING_DIRECTORIES &&
+	cd a &&
+	mkdir -p .git/info &&
+	cd ../..
+
+'
+
+test_expect_success 'Ignore fake .git/info/exclude' '
+	(
+		cd t/a &&
+		echo v > .git/info/exclude &&
+		git grep --no-index vvv . &&
+		rm .git/info/exclude
+	)
+'
+
+test_expect_success 'Unsetup fake .git' '
+	rm -rf t/a &&
+	unset GIT_CEILING_DIRECTORIES
+'
+
 test_done
-- 
1.7.0.1.384.g6abcaa
Previous: Nguyễn Thái Ngọc DuyNext: Nguyễn Thái Ngọc Duy
Message 13 of 20 in “nd/setup part two”
  1. 00/16 nd/setup part twoNguyễn Thái Ngọc Duy, Mar 11, 2010
  2. 01/16 Move enter_repo() to setup.cNguyễn Thái Ngọc Duy, Mar 11, 2010
  3. 02/16 enter_repo(): initialize other variables as setup_git_directory_gently() doesNguyễn Thái Ngọc Duy, Mar 11, 2010
  4. 03/16 rev-parse --git-dir: print relative gitdir correctlyNguyễn Thái Ngọc Duy, Mar 11, 2010
  5. 04/16 worktree setup: call set_git_dir explicitlyNguyễn Thái Ngọc Duy, Mar 11, 2010
  6. Junio C HamanoMar 11, 2010
  7. 05/16 Add git_config_early()Nguyễn Thái Ngọc Duy, Mar 11, 2010
  8. 06/16 Use git_config_early() instead of git_config() during repo setupNguyễn Thái Ngọc Duy, Mar 11, 2010
  9. Nguyen Thai Ngoc DuyMar 12, 2010
  10. 07/16 worktree setup: restore original state when things go wrongNguyễn Thái Ngọc Duy, Mar 11, 2010
  11. 08/16 init/clone: turn on startup->have_repository properlyNguyễn Thái Ngọc Duy, Mar 11, 2010
  12. 09/16 git_config(): do not read .git/config if there is no repositoryNguyễn Thái Ngọc Duy, Mar 11, 2010
  13. 10/16 Do not read .git/info/exclude if there is no repositoryNguyễn Thái Ngọc Duy, Mar 11, 2010
  14. 11/16 Do not read .git/info/attributes if there is no repositoryNguyễn Thái Ngọc Duy, Mar 11, 2010
  15. 12/16 apply: do not check sha1 when repository has not been foundNguyễn Thái Ngọc Duy, Mar 11, 2010
  16. 13/16 config: do not read .git/config if there is no repositoryNguyễn Thái Ngọc Duy, Mar 11, 2010
  17. 14/16 Allow to undo setup_git_directory_gently() gracefully (and fix alias code)Nguyễn Thái Ngọc Duy, Mar 11, 2010
  18. 15/16 alias: keep repository found while collecting aliases as long as possibleNguyễn Thái Ngọc Duy, Mar 11, 2010
  19. 16/16 Guard unallowed access to repository when it's not set upNguyễn Thái Ngọc Duy, Mar 11, 2010
  20. Nguyen Thai Ngoc DuyMar 20, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.