[PATCH 1/2] submodule summary: do not shift a non-existent positional variable

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 3, 2010, 22:19 UTC
Message-ID: <1267654750-30911-1-git-send-email-gitster@pobox.com>

From: Jeff King <peff@peff.net>

When "git submodule summary" is run without any argument, we default to compare the state of index with the HEAD, but tried to shift out $1 that does not exist (and worse yet, we didn't use it).

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 git-submodule.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git-submodule.sh b/git-submodule.sh
index 5869c00..383dc45 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -556,7 +556,7 @@ cmd_summary() {
 	if rev=$(git rev-parse -q --verify --default HEAD ${1+"$1"})
 	then
 		head=$rev
-		shift
+		test $# = 0 || shift
 	elif test -z "$1" -o "$1" = "HEAD"
 	then
 		return

-- 
1.7.0.1.290.g2d87e