git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv4 0/4] Using git-mailsplit in mixed line ending environment

From
SHStefan-W. Hahn <stefan.hahn@s-hahn.de>
Date
Feb 27, 2010, 14:20 UTC
Message-ID
<1267280428-18223-1-git-send-email-stefan.hahn@s-hahn.de>
In-Reply-To
<1266080362-24760-1-git-send-email-stefan.hahn@s-hahn.de>
Hello,

I'm using git in environments with files having dos or unix line ending. I apply patches using 'git format-patch ... | git am ...'. A change in git-mailsplit in commit c2ca1d79 introduced a change in the default behaviour of git-mailsplit when splitting mbox patches. It makes dos line endings to unix line endings. With this behaviour it is impossible to apply patches.

The following patches introduce the '--kepp-cr', '--no-keep-cr' parameter to git-am an an additional possibility to set '--keep-cr' via configuration for git-am. Also I added missing description for '--keep-cr' of git-mailsplit.

Second round: I changed 'mailsplit.keep-cr' to 'mailsplit.keepcr' as suggested by Jakub and comment in the testcase.

Third round: I moved configuration 'mailsplit.keepcr' to 'am.keepcr' because git-mailsplit can be used outside a git repository (thx Junio).

Fourth round: I considered the replies from Junio and split up the patch introducing configuration am.keepcr in two. I introduced an '--no-keep-cr' to overwrite configuration. I removed git-mailsplit tests from the test suite, they only showed the behaviour when using dos line ending. I added some tests to show the correct behaviour in different situations using the new parameters and configuration.

Stefan
[PATCH 1/4] git-mailsplit: Show parameter '--keep-cr' in usage and documentation
[PATCH 2/4] git-am: Add command line parameter `--keep-cr` passing it to git-mailsplit.
[PATCH 3/4] git-am: Add configuration am.keepcr and parameter --no-keep-cr to override configuration.
[PATCH 4/4] git-am: Adding tests for `--keep-cr`, `--no-keep-cr` and `am.keepcr`.
 
Documentation/config.txt        |    7 +++
Documentation/git-am.txt        |    9 +++-
Documentation/git-mailsplit.txt |    5 ++-
builtin-mailsplit.c             |    2 +-
git-am.sh                       |   32 ++++++++++---
t/t4253-am-keep-cr-dos.sh       |   96 +++++++++++++++++++++++++++++++++++++++
6 files changed, 141 insertions(+), 10 deletions(-)
Previous: Junio C HamanoNext: Junio C Hamano
Message 10 of 15 in “[PATCHv3 0/3] Using git-mailsplit in mixed line ending environment”
  1. Stefan-W. HahnFeb 13, 2010
  2. 1/3 git-mailsplit: Show parameter '--keep-cr' in usage and documentationStefan-W. Hahn, Feb 13, 2010
  3. 2/3 git-am: Add command line parameter `--keep-cr` passing it to git-mailsplit.Stefan-W. Hahn, Feb 13, 2010
  4. 3/3 Adding test for `--keep-cr` for git-am.Stefan-W. Hahn, Feb 13, 2010
  5. 1/3 git-mailsplit: Show parameter '--keep-cr' in usage and documentationStefan-W. Hahn, Feb 13, 2010
  6. 2/3 git-am: Add command line parameter `--keep-cr` passing it to git-mailsplit.Stefan-W. Hahn, Feb 13, 2010
  7. Junio C HamanoFeb 22, 2010
  8. 3/3 Adding test for `--keep-cr` for git-am.Stefan-W. Hahn, Feb 13, 2010
  9. Junio C HamanoFeb 22, 2010
  10. 0/4 Using git-mailsplit in mixed line ending environmentStefan-W. Hahn, Feb 27, 2010
  11. Junio C HamanoFeb 28, 2010
  12. 1/4 git-mailsplit: Show parameter '--keep-cr' in usage and documentationStefan-W. Hahn, Feb 27, 2010
  13. 2/4 git-am: Add command line parameter `--keep-cr` passing it to git-mailsplit.Stefan-W. Hahn, Feb 27, 2010
  14. 3/4 git-am: Add configuration am.keepcr and parameter --no-keep-cr to override configuration.Stefan-W. Hahn, Feb 27, 2010
  15. 4/4 git-am: Adding tests for `--keep-cr`, `--no-keep-cr` and `am.keepcr`.Stefan-W. Hahn, Feb 27, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.