git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] builtin-fetch --all/--multi: propagate options correctly

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 24, 2010, 18:22 UTC
Message-ID
<1267035726-2815-2-git-send-email-gitster@pobox.com>
In-Reply-To
<1267035726-2815-1-git-send-email-gitster@pobox.com>

When running a subfetch, the code propagated some options but not others. Propagate --force, --update-head-ok and --keep options as well.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 builtin-fetch.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/builtin-fetch.c b/builtin-fetch.c
index 8654fa7..61b2e40 100644
--- a/builtin-fetch.c
+++ b/builtin-fetch.c
@@ -784,13 +784,19 @@ static int add_remote_or_group(const char *name, struct string_list *list)
 static int fetch_multiple(struct string_list *list)
 {
 	int i, result = 0;
-	const char *argv[] = { "fetch", NULL, NULL, NULL, NULL, NULL, NULL };
+	const char *argv[10] = { "fetch" };
 	int argc = 1;
 
 	if (dry_run)
 		argv[argc++] = "--dry-run";
 	if (prune)
 		argv[argc++] = "--prune";
+	if (update_head_ok)
+		argv[argc++] = "--update-head-ok";
+	if (force)
+		argv[argc++] = "--force";
+	if (keep)
+		argv[argc++] = "--keep";
 	if (verbosity >= 2)
 		argv[argc++] = "-v";
 	if (verbosity >= 1)
@@ -801,6 +807,7 @@ static int fetch_multiple(struct string_list *list)
 	for (i = 0; i < list->nr; i++) {
 		const char *name = list->items[i].string;
 		argv[argc] = name;
+		argv[argc + 1] = NULL;
 		if (verbosity >= 0)
 			printf("Fetching %s\n", name);
 		if (run_command_v_opt(argv, RUN_GIT_CMD)) {
-- 
1.7.0.207.gac4ec
Previous: Junio C HamanoNext: Junio C Hamano
Message 2 of 7 in “t5521: fix and modernize”
  1. 1/2 t5521: fix and modernizeJunio C Hamano, Feb 24, 2010
  2. 2/2 builtin-fetch --all/--multi: propagate options correctlyJunio C Hamano, Feb 24, 2010
  3. 3/3 fetch --all/--multiple: keep all the fetched branch informationJunio C Hamano, Feb 24, 2010
  4. Teemu LikonenFeb 24, 2010
  5. Michael LukashovFeb 24, 2010
  6. Junio C HamanoFeb 24, 2010
  7. Michael LukashovFeb 24, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.