git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv3 2/5] connect: use static list of repo-local env vars

From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date
Feb 23, 2010, 23:35 UTC
Message-ID
<1266968136-11129-3-git-send-email-giuseppe.bilotta@gmail.com>
In-Reply-To
<1266968136-11129-1-git-send-email-giuseppe.bilotta@gmail.com>

This adds the missing GIT_CONFIG to the list of env vars that should be cleared.

Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
---
 connect.c |   13 +------------
 1 files changed, 1 insertions(+), 12 deletions(-)
diff --git a/connect.c b/connect.c
index 9f39038..94b3707 100644
--- a/connect.c
+++ b/connect.c
@@ -582,18 +582,7 @@ struct child_process *git_connect(int fd[2], const char *url_orig,
 		*arg++ = host;
 	}
 	else {
-		/* remove these from the environment */
-		const char *env[] = {
-			ALTERNATE_DB_ENVIRONMENT,
-			DB_ENVIRONMENT,
-			GIT_DIR_ENVIRONMENT,
-			GIT_WORK_TREE_ENVIRONMENT,
-			GRAFT_ENVIRONMENT,
-			INDEX_ENVIRONMENT,
-			NO_REPLACE_OBJECTS_ENVIRONMENT,
-			NULL
-		};
-		conn->env = env;
+		conn->env = local_repo_env;
 		conn->use_shell = 1;
 	}
 	*arg++ = cmd.buf;
-- 
1.7.0.200.g5ba36.dirty
Previous: Giuseppe BilottaNext: Johannes Sixt
Message 3 of 8 in “[PATCHv3 0/5] repo-local env vars handling”
  1. Giuseppe BilottaFeb 23, 2010
  2. 1/5 cache: static list of repo-local env varsGiuseppe Bilotta, Feb 23, 2010
  3. 2/5 connect: use static list of repo-local env varsGiuseppe Bilotta, Feb 23, 2010
  4. Johannes SixtFeb 24, 2010
  5. Giuseppe BilottaFeb 24, 2010
  6. 3/5 rev-parse: --local-env-vars optionGiuseppe Bilotta, Feb 23, 2010
  7. 4/5 shell setup: clear_local_git_env() functionGiuseppe Bilotta, Feb 23, 2010
  8. 5/5 submodules: ensure clean environment when operating in a submoduleGiuseppe Bilotta, Feb 23, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.