git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 5/6] git_mkstemps_mode: don't set errno to EINVAL for any error.

From
Matthieu Moy <matthieu.moy@imag.fr>
Date
Feb 19, 2010, 23:21 UTC
Message-ID
<1266621718-4879-5-git-send-email-Matthieu.Moy@imag.fr>
In-Reply-To
<vpq7hq8stjt.fsf@bauges.imag.fr>
Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
---
 path.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/path.c b/path.c
index 005b836..2886eb6 100644
--- a/path.c
+++ b/path.c
@@ -222,7 +222,9 @@ int git_mkstemps_mode(char *pattern, int suffix_len, int mode)
 	}
 	/* We return the null string if we can't find a unique file name.  */
 	pattern[0] = '\0';
-	errno = EINVAL;
+	/* Make sure errno signals an error on failure */
+	if (errno <= 0)
+		errno = EINVAL;
 	return -1;
 }
 
-- 
1.7.0.rc2.92.gb6a04
Previous: Matthieu MoyNext: Junio C Hamano
Message 7 of 11 in “Re: [PATCH 4/4] Use git_mkstemp_mode and xmkstemp_mode in odb_mkstemp, not chmod later.”
  1. Matthieu MoyFeb 19, 2010
  2. 1/6 Add a testcase for ACL with restrictive umask.Matthieu Moy, Feb 19, 2010
  3. 2/6 Move gitmkstemps to path.cMatthieu Moy, Feb 19, 2010
  4. 3/6 git_mkstemp_mode, xmkstemp_mode: variants of gitmkstemps with mode argument.Matthieu Moy, Feb 19, 2010
  5. Junio C HamanoFeb 20, 2010
  6. 4/6 Use git_mkstemp_mode and xmkstemp_mode in odb_mkstemp, not chmod later.Matthieu Moy, Feb 19, 2010
  7. 5/6 git_mkstemps_mode: don't set errno to EINVAL for any error.Matthieu Moy, Feb 19, 2010
  8. Junio C HamanoFeb 20, 2010
  9. Matthieu MoyFeb 22, 2010
  10. Junio C HamanoFeb 22, 2010
  11. 6/6 Use git_mkstemp_mode instead of plain mkstemp to create object filesMatthieu Moy, Feb 19, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.