[PATCH 00/10] teach --progress to transport-related builtins
- From
Tay Ray Chuan <rctay89@gmail.com>
- Date
- Feb 18, 2010, 12:37 UTC
- Message-ID
- <1266496631-3980-1-git-send-email-rctay89@gmail.com>
This patch series adds --progress to:
- git-fetch - git-pull - git-push
I suspect the most contentious issue in this patch series would be the logic that determines whether progress reporting is done. This is found in patch 6 for transport.c::transport_set_verbosity().
As a guide, I used Jeff's message (gmane#121065). The rules used are as follows (processing aborts when a rule is satisfied):
1. Report progress, if force_progress is 1 (ie. --progress). 2. Don't report progress, if verbosity < 0 (ie. -q/--quiet). 3. Report progress if isatty(2) is 1.
This changes the current implementation such that if both --progress and --quiet are specified, progress is reported. I don't think this is a very significant change, but I think it makes sense, since I expect --progress to be mostly used by script writers or IDE integrators (to force progress reporting even if stderr is not a terminal).
Contents:
[PATCH 01/10] Documentation/git-pull.txt: mention --quiet and --verbose for fetching [PATCH 02/10] Documentation/git-push.txt: put --quiet before --verbose [PATCH 03/10] fetch: refactor verbosity option handling into transport.[ch] [PATCH 04/10] push: support multiple levels of verbosity [PATCH 05/10] clone: support multiple levels of verbosity [PATCH 06/10] transport->progress: use flag authoritatively [PATCH 07/10] push: learn --progress [PATCH 08/10] fetch: learn --progress [PATCH 09/10] pull: learn --progress [PATCH 10/10] transport: update flags to be in running order
Documentation/fetch-options.txt | 11 ++++++++--- Documentation/git-push.txt | 15 +++++++++++---- builtin-clone.c | 19 ++++++------------- builtin-fetch.c | 7 +++---- builtin-push.c | 11 ++++++++--- git-pull.sh | 6 ++++-- transport-helper.c | 4 +--- transport.c | 31 ++++++++++++++++++++++++++----- transport.h | 15 ++++++++++----- 9 files changed, 77 insertions(+), 42 deletions(-)
-- Cheers, Ray Chuan