git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 00/10] teach --progress to transport-related builtins

From
Tay Ray Chuan <rctay89@gmail.com>
Date
Feb 18, 2010, 12:37 UTC
Message-ID
<1266496631-3980-1-git-send-email-rctay89@gmail.com>
This patch series adds --progress to:
  - git-fetch
  - git-pull
  - git-push

I suspect the most contentious issue in this patch series would be the logic that determines whether progress reporting is done. This is found in patch 6 for transport.c::transport_set_verbosity().

As a guide, I used Jeff's message (gmane#121065). The rules used are as follows (processing aborts when a rule is satisfied):

  1. Report progress, if force_progress is 1 (ie. --progress).
  2. Don't report progress, if verbosity < 0 (ie. -q/--quiet).
  3. Report progress if isatty(2) is 1.

This changes the current implementation such that if both --progress and --quiet are specified, progress is reported. I don't think this is a very significant change, but I think it makes sense, since I expect --progress to be mostly used by script writers or IDE integrators (to force progress reporting even if stderr is not a terminal).

Contents:

[PATCH 01/10] Documentation/git-pull.txt: mention --quiet and --verbose for fetching [PATCH 02/10] Documentation/git-push.txt: put --quiet before --verbose [PATCH 03/10] fetch: refactor verbosity option handling into transport.[ch] [PATCH 04/10] push: support multiple levels of verbosity [PATCH 05/10] clone: support multiple levels of verbosity [PATCH 06/10] transport->progress: use flag authoritatively [PATCH 07/10] push: learn --progress [PATCH 08/10] fetch: learn --progress [PATCH 09/10] pull: learn --progress [PATCH 10/10] transport: update flags to be in running order

 Documentation/fetch-options.txt |   11 ++++++++---
 Documentation/git-push.txt      |   15 +++++++++++----
 builtin-clone.c                 |   19 ++++++-------------
 builtin-fetch.c                 |    7 +++----
 builtin-push.c                  |   11 ++++++++---
 git-pull.sh                     |    6 ++++--
 transport-helper.c              |    4 +---
 transport.c                     |   31 ++++++++++++++++++++++++++-----
 transport.h                     |   15 ++++++++++-----
 9 files changed, 77 insertions(+), 42 deletions(-)

-- Cheers, Ray Chuan

Next: Tay Ray Chuan
Message 1 of 16 in “teach --progress to transport-related builtins”
  1. 00/10 teach --progress to transport-related builtinsTay Ray Chuan, Feb 18, 2010
  2. 01/10 Documentation/git-pull.txt: mention --quiet and --verbose for fetchingTay Ray Chuan, Feb 18, 2010
  3. Junio C HamanoFeb 18, 2010
  4. Tay Ray ChuanFeb 19, 2010
  5. 02/10 Documentation/git-push.txt: put --quiet before --verboseTay Ray Chuan, Feb 18, 2010
  6. 03/10 fetch: refactor verbosity option handling into transport.[ch]Tay Ray Chuan, Feb 18, 2010
  7. 04/10 push: support multiple levels of verbosityTay Ray Chuan, Feb 18, 2010
  8. 05/10 clone: support multiple levels of verbosityTay Ray Chuan, Feb 18, 2010
  9. 06/10 transport->progress: use flag authoritativelyTay Ray Chuan, Feb 18, 2010
  10. 07/10 push: learn --progressTay Ray Chuan, Feb 18, 2010
  11. 08/10 fetch: learn --progressTay Ray Chuan, Feb 18, 2010
  12. 09/10 pull: learn --progressTay Ray Chuan, Feb 18, 2010
  13. 10/10 transport: update flags to be in running orderTay Ray Chuan, Feb 18, 2010
  14. Junio C HamanoFeb 19, 2010
  15. Tay Ray ChuanFeb 19, 2010
  16. Jeff KingFeb 19, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.