git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 1/5] make_absolute_path(): Do not append redundant slash

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Feb 14, 2010, 15:44 UTC
Message-ID
<1266162285-10955-1-git-send-email-pclouds@gmail.com>

When concatenating two paths, if the first one already have '/', do not put another '/' in between the two paths.

Usually this is not the case as getcwd() won't return '/foo/bar/', except when you are standing at root, then it will return '/'.

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 abspath.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/abspath.c b/abspath.c
index b88122c..c91a29c 100644
--- a/abspath.c
+++ b/abspath.c
@@ -54,8 +54,9 @@ const char *make_absolute_path(const char *path)
 			if (len + strlen(last_elem) + 2 > PATH_MAX)
 				die ("Too long path name: '%s/%s'",
 						buf, last_elem);
-			buf[len] = '/';
-			strcpy(buf + len + 1, last_elem);
+			if (len && buf[len-1] != '/')
+				buf[len++] = '/';
+			strcpy(buf + len, last_elem);
 			free(last_elem);
 			last_elem = NULL;
 		}
-- 
1.7.0.195.g637a2
Next: Nguyễn Thái Ngọc Duy
Message 1 of 8 in “make_absolute_path(): Do not append redundant slash”
  1. 1/5 make_absolute_path(): Do not append redundant slashNguyễn Thái Ngọc Duy, Feb 14, 2010
  2. 2/5 init-db, rev-parse --git-dir: do not append redundant slashNguyễn Thái Ngọc Duy, Feb 14, 2010
  3. 3/5 Move offset_1st_component() to path.cNguyễn Thái Ngọc Duy, Feb 14, 2010
  4. Johannes SixtFeb 15, 2010
  5. 3/5 Move offset_1st_component() to path.c=?UTF-8?q?Nguy=E1=BB=85n=20Th=C3=A1i=20Ng=E1=BB=8Dc=20Duy?=, Feb 16, 2010
  6. Johannes SixtFeb 16, 2010
  7. 4/5 Support working directory located at rootNguyễn Thái Ngọc Duy, Feb 14, 2010
  8. 5/5 Add test for using Git at root of file systemNguyễn Thái Ngọc Duy, Feb 14, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.