git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Current stgit asks SMTP password for every patch

From
PRPavel Roskin <proski@gnu.org>
Date
Feb 7, 2010, 02:18 UTC
Message-ID
<1265509110.10712.22.camel@mj>
Hello, Alex!

I was unpleasantly surprised when the current STGit started asking me for the SMTP password for every patch in the series:

$ stg mail --to minicom ncurses-const..clobber Checking the validity of the patches ... done Sending patch "ncurses-const" ... Please enter SMTP password: done Sending patch "precision-int" ... Please enter SMTP password: done Sending patch "aliasing" ... Please enter SMTP password: done Sending patch "clobber" ... Please enter SMTP password: done

The code in __send_message_smtp() lacks any caching for the smtppassword variable. The code comes from your commit 89d7ec43e0b25cc6cbc9feb044d7ce7048f224eb stg mail: Refactor __send_message and friends

Ideally, asking for the password (as well as other verification of the e-mail credentials) should be done before "Sending patch" is shown, and before the cover letter if any. That is, it should be in func() in stgit/commands/mail.py.

But I'll also be fine with a simple-minded password caching in __send_message_smtp().

-- 
Regards,
Pavel Roskin
Message 1 of 1 in “Current stgit asks SMTP password for every patch”
  1. Pavel RoskinFeb 7, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.