git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv12 13/23] t3301: Verify successful annotation of non-commits

From
Johan Herland <johan@herland.net>
Date
Jan 27, 2010, 11:51 UTC
Message-ID
<1264593120-4428-14-git-send-email-johan@herland.net>
In-Reply-To
<1264593120-4428-1-git-send-email-johan@herland.net>

Adds a testcase verifying that git-notes works successfully on tree, blob, and tag objects.

Signed-off-by: Johan Herland <johan@herland.net>
---
 t/t3301-notes.sh |   17 +++++++++++++++++
 1 files changed, 17 insertions(+), 0 deletions(-)
diff --git a/t/t3301-notes.sh b/t/t3301-notes.sh
index 10f62f4..fd5e593 100755
--- a/t/t3301-notes.sh
+++ b/t/t3301-notes.sh
@@ -282,4 +282,21 @@ test_expect_success 'Do not show note when core.notesRef is overridden' '
 	test_cmp expect-not-other output
 '
 
+test_expect_success 'Allow notes on non-commits (trees, blobs, tags)' '
+	echo "Note on a tree" > expect
+	git notes edit -m "Note on a tree" HEAD: &&
+	git notes show HEAD: > actual &&
+	test_cmp expect actual &&
+	echo "Note on a blob" > expect
+	filename=$(git ls-tree --name-only HEAD | head -n1) &&
+	git notes edit -m "Note on a blob" HEAD:$filename &&
+	git notes show HEAD:$filename > actual &&
+	test_cmp expect actual &&
+	echo "Note on a tag" > expect
+	git tag -a -m "This is an annotated tag" foobar HEAD^ &&
+	git notes edit -m "Note on a tag" foobar &&
+	git notes show foobar > actual &&
+	test_cmp expect actual
+'
+
 test_done
-- 
1.6.6.405.g80ed6
Previous: Johan HerlandNext: Johan Herland
Message 16 of 31 in “[PATCHv12 00/23] git notes”
  1. Johan HerlandJan 27, 2010
  2. 01/23 Minor non-functional fixes to notes.cJohan Herland, Jan 27, 2010
  3. Junio C HamanoJan 27, 2010
  4. Johan HerlandJan 27, 2010
  5. 02/23 Notes API: get_commit_notes() -> format_note() + remove the commit restrictionJohan Herland, Jan 27, 2010
  6. 03/23 Add tests for checking correct handling of $GIT_NOTES_REF and core.notesRefJohan Herland, Jan 27, 2010
  7. 04/23 Notes API: init_notes(): Initialize the notes tree from the given notes refJohan Herland, Jan 27, 2010
  8. 05/23 Notes API: add_note(): Add note objects to the internal notes tree structureJohan Herland, Jan 27, 2010
  9. 06/23 Notes API: remove_note(): Remove note objects from the notes tree structureJohan Herland, Jan 27, 2010
  10. 07/23 Notes API: get_note(): Return the note annotating the given objectJohan Herland, Jan 27, 2010
  11. 08/23 Notes API: for_each_note(): Traverse the entire notes tree with a callbackJohan Herland, Jan 27, 2010
  12. 09/23 Notes API: write_notes_tree(): Store the notes tree in the databaseJohan Herland, Jan 27, 2010
  13. 10/23 Notes API: Allow multiple concurrent notes trees with new struct notes_treeJohan Herland, Jan 27, 2010
  14. 11/23 Refactor notes concatenation into a flexible interface for combining notesJohan Herland, Jan 27, 2010
  15. 12/23 Builtin-ify git-notesJohan Herland, Jan 27, 2010
  16. 13/23 t3301: Verify successful annotation of non-commitsJohan Herland, Jan 27, 2010
  17. 14/23 t3305: Verify that adding many notes with git-notes triggers increased fanoutJohan Herland, Jan 27, 2010
  18. 15/23 Teach notes code to properly preserve non-notes in the notes treeJohan Herland, Jan 27, 2010
  19. 16/23 Teach builtin-notes to remove empty notesJohan Herland, Jan 27, 2010
  20. 17/23 builtin-notes: Add "remove" subcommand for removing existing notesJohan Herland, Jan 27, 2010
  21. 18/23 t3305: Verify that removing notes triggers automatic fanout consolidationJohan Herland, Jan 27, 2010
  22. 19/23 Notes API: prune_notes(): Prune notes that belong to non-existing objectsJohan Herland, Jan 27, 2010
  23. 20/23 builtin-notes: Add "prune" subcommand for removing notes for missing objectsJohan Herland, Jan 27, 2010
  24. 21/23 Documentation: Generalize git-notes docs to 'objects' instead of 'commits'Johan Herland, Jan 27, 2010
  25. 22/23 builtin-notes: Add "list" subcommand for listing note objectsJohan Herland, Jan 27, 2010
  26. 23/23 builtin-notes: Add "add" subcommand for appending to note objectsJohan Herland, Jan 27, 2010
  27. Junio C HamanoJan 27, 2010
  28. Sverre RabbelierJan 27, 2010
  29. Johan HerlandJan 27, 2010
  30. Junio C HamanoJan 28, 2010
  31. Johan HerlandJan 28, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.