git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv3 2/3] t0022: replace non-portable literal CR

From
Stephen Boyd <bebarino@gmail.com>
Date
Jan 26, 2010, 00:33 UTC
Message-ID
<1264466039-22431-3-git-send-email-bebarino@gmail.com>
In-Reply-To
<1264466039-22431-1-git-send-email-bebarino@gmail.com>
We shouldn't have literal CR's in tests as they aren't portable.
Signed-off-by: Stephen Boyd <bebarino@gmail.com>
---
Hopefully this isn't botched over the wire.
 t/t0022-crlf-rename.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/t/t0022-crlf-rename.sh b/t/t0022-crlf-rename.sh
index f1e1d48..7af3fbc 100755
--- a/t/t0022-crlf-rename.sh
+++ b/t/t0022-crlf-rename.sh
@@ -12,7 +12,7 @@ test_expect_success setup '
 	test_tick &&
 	git commit -m Initial &&
 
-	sed -e "s/\$/
/" "$TEST_DIRECTORY"/t0022-crlf-rename.sh >elpmas &&
+	append_cr <"$TEST_DIRECTORY"/t0022-crlf-rename.sh >elpmas &&
 	git add elpmas &&
 	rm -f sample &&
 
-- 
1.7.0.rc0
Previous: Stephen BoydNext: Stephen Boyd
Message 3 of 5 in “[PATCHv3 0/3] Fix patch detection for thunderbird saved mails”
  1. Stephen BoydJan 26, 2010
  2. 1/3 tests: consolidate CR removal/addition functionsStephen Boyd, Jan 26, 2010
  3. 2/3 t0022: replace non-portable literal CRStephen Boyd, Jan 26, 2010
  4. 3/3 am: fix patch format detection for Thunderbird "Save As" emailsStephen Boyd, Jan 26, 2010
  5. Junio C HamanoJan 26, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.