git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC PATCH v2 0/2] Imporove remote helper exec failure reporting

From
ILIlari Liusvaara <ilari.liusvaara@elisanet.fi>
Date
Jan 9, 2010, 13:45 UTC
Message-ID
<1263044757-12560-1-git-send-email-ilari.liusvaara@elisanet.fi>
(This is newer than updated patch v3).

I decided to go on a bit further with new features, and that's why this is back as RFC.

Diffrences from first RFC round:
- Split loop-over-close to its own function and warn but not retry on
  bizarre error codes (basically anything except EBADF and EINTR).
- Don't rely on pipe(2) to preserve the fd array on failure.
- Add some testcases.
- Fix buggy behaviour if report pipe read end winds up as fd #0.
- Set silent_exec_failure on executing remote helper.
- Make exec reporting in presence of preexec_cb controlled by flag to
  solve pager deadlock problems without preventing using preexec_cb
  with exec reporting entierely (the way pager is invoked is just
  fundamentially incompatible with exec reporting).
- Add flag to make run-command give different code for exec failing due to
  ENOENT than for other failures (including other ways to get ENOENT).
- change chdir failure to be reported as error (and pass error code back).
  BTW: Nothing seems to use that chdir feature, aside of new testcase.
- Report errors to parent's stderr.
- Don't retry waitpid on bizarre error codes (basically anything except
  EINTR).
- Make run_command actually complain about exec failing (as API docs
  say).
Ilari Liusvaara (2):
  Report exec errors from run-command
  Improve transport helper exec failure reporting
 Documentation/technical/api-run-command.txt |    2 +
 Makefile                                    |    1 +
 run-command.c                               |  196 +++++++++++++++++++++++++--
 run-command.h                               |    2 +
 t/t0061-run-command.sh                      |   20 +++
 test-run-command.c                          |   74 ++++++++++
 transport-helper.c                          |   27 +++-
 7 files changed, 305 insertions(+), 17 deletions(-)
 create mode 100755 t/t0061-run-command.sh
 create mode 100644 test-run-command.c
Next: Ilari Liusvaara
Message 1 of 11 in “Imporove remote helper exec failure reporting”
  1. 0/2 Imporove remote helper exec failure reportingIlari Liusvaara, Jan 9, 2010
  2. 1/2 Report exec errors from run-commandIlari Liusvaara, Jan 9, 2010
  3. 0/4 Detect exec errors in start_command earlyJohannes Sixt, Jan 10, 2010
  4. 1/4 start_command: report child process setup errors to the parent's stderrJohannes Sixt, Jan 10, 2010
  5. 2/4 run-command: move wait_or_whine earlierJohannes Sixt, Jan 10, 2010
  6. 3/4 start_command: detect execvp failures earlyJohannes Sixt, Jan 10, 2010
  7. Junio C HamanoJan 14, 2010
  8. Johannes SixtJan 14, 2010
  9. Junio C HamanoJan 14, 2010
  10. 4/4 Improve error message when a transport helper was not foundJohannes Sixt, Jan 10, 2010
  11. 2/2 Improve transport helper exec failure reportingIlari Liusvaara, Jan 9, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.