git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv3 0/4 (resent)] Miscelanous gitweb improvements from J.H.

From
Jakub Narebski <jnareb@gmail.com>
Date
Jan 3, 2010, 16:07 UTC
Message-ID
<1262534850-24572-1-git-send-email-jnareb@gmail.com>
This is resend of early part of "[PATCH 0/6] Gitweb caching changes v2"
thread by John 'Warthog9' Hawley (J.H.),
  Message-ID: <1260488743-25855-1-git-send-email-warthog9@kernel.org>
  http://thread.gmane.org/gmane.comp.version-control.git/135052
or alternatively
  git://git.kernel.org/pub/scm/git/warthog9/gitweb.git gitweb-ml-v2

with a few modifications of my own. Those patches were send originally as responses in the mentioned thread, for further comments from original author. As the discussion didn't pick up (because of kernel.org upgrade, and perhaps due to end-of-year stuff), I am resending those patches in a separate thread for a better visibility; only comments are changed.

This series of patches is rebased on top of commit 37bae10 (Merge branch 'maint', 2009-12-31) in 'master' branch.

Change that apply to all patches in series: 
* moving from "GITWEB - " to "gitweb: " as subsystem prefix
* changing author to John 'Warthog9' Hawley <warthog9@kernel.org>
  (it was John 'Warthog9' Hawley <warthog9@eaglescrag.net>)
* add signoff or change it to John 'Warthog9' Hawley <warthog9@kernel.org>,
  and of course add my own signoff.

I have included reply to neither "GITWEB - File based caching layer" nor "GITWEB - Separate defaults from main file" in this thread/series.

I haven't included the main point of the whole series, namely adding response caching layer in the form that is used in git.kernel.org, because I think this patch should be split into smaller parts, and unit-tested. As it is now it is a bit of mess. I have done patch which makes gitweb always use explicit filehandle when printing (simplifying a bit it replaces 'print <something>' by 'print {$out} <something>', with $out set to \*STDOUT), as a patch that prepares for (optional) gitweb caching, while not affecting throughput, latency and memory consumption when caching is disabled, as opposed to original solution by J.H. of always storing whole response in scalar and writing it at the end.

I haven't included splitting of gitweb_defaults.perl off gitweb.perl, as it was after large and invasive gitweb caching patch, it would require substantial changes to gitweb tests upfront (by testing built gitweb.cgi and not source gitweb.perl), and needs fixing of Makefile to actually work reliably (we could have to process both gitweb.perl and gitweb_defaults.perl, while provided Makefile process only the file which triggered the rule... I think).

I am not sure if 'gitweb: Add option to force version match' is a good solution to the problem it tires to address, i.e. if it is worth having, and I am not sure if I did 'gitweb: Makefile improvements' correctly.

John 'Warthog9' Hawley (4):
  gitweb: Load checking
  gitweb: Add option to force version match
  gitweb: Optionally add "git" links in project list page
  gitweb: Makefile improvements
 Makefile           |   65 +++++---------------------
 gitweb/Makefile    |  129 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 gitweb/README      |   14 +++++-
 gitweb/gitweb.perl |   80 ++++++++++++++++++++++++++++++--
 4 files changed, 230 insertions(+), 58 deletions(-)
 create mode 100644 gitweb/Makefile
John, any comments?
-- 
Jakub Narebski
ShadeHawk or jnareb on #git
Poland
Next: Jakub Narebski
Message 1 of 10 in “[PATCHv3 0/4 (resent)] Miscelanous gitweb improvements from J.H.”
  1. Jakub NarebskiJan 3, 2010
  2. 1/4 gitweb: Load checkingJakub Narebski, Jan 3, 2010
  3. 2/4 gitweb: Add option to force version matchJakub Narebski, Jan 3, 2010
  4. 3/4 gitweb: Optionally add "git" links in project list pageJakub Narebski, Jan 3, 2010
  5. 4/4 gitweb: Makefile improvementsJakub Narebski, Jan 3, 2010
  6. J.H.Jan 6, 2010
  7. Jakub NarebskiJan 6, 2010
  8. Jakub NarebskiJan 9, 2010
  9. J.H.Jan 12, 2010
  10. Jakub NarebskiJan 12, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.