git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-svn: Remove obsolete MAXPARENT check

From
Andrew Myrick <amyrick@apple.com>
Date
Dec 21, 2009, 22:22 UTC
Message-ID
<1261434174-298-1-git-send-email-amyrick@apple.com>
Change git-svn not to impose a limit of 16 parents on a merge.

This limit in git-svn artificially prevents cloning svn repositories that contain commits with more than 16 merge parents.

The limit was removed from builtin-commit-tree.c for git v1.6.0 in commit ef98c5cafb3e799b1568bb843fcd45920dc62f16, so there is no need to check for it it in git-svn.

Signed-off-by: Andrew Myrick <amyrick@apple.com>
---
 git-svn.perl |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/git-svn.perl b/git-svn.perl
index 0a6460e..92c40da 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -2447,12 +2447,6 @@ sub get_commit_parents {
 		next if $seen{$p};
 		$seen{$p} = 1;
 		push @ret, $p;
-		# MAXPARENT is defined to 16 in commit-tree.c:
-		last if @ret >= 16;
-	}
-	if (@tmp) {
-		die "r$log_entry->{revision}: No room for parents:\n\t",
-		    join("\n\t", @tmp), "\n";
 	}
 	@ret;
 }
-- 
1.6.6.rc3.dirty
Next: Eric Wong
Message 1 of 2 in “git-svn: Remove obsolete MAXPARENT check”
  1. git-svn: Remove obsolete MAXPARENT checkAndrew Myrick, Dec 21, 2009
  2. Eric WongDec 21, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.