git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] Fix applying a line when all following lines are deletions

From
jepler@unpythonic.net <jepler@unpythonic.net>
Date
Dec 8, 2009, 00:22 UTC
Message-ID
<1260231763-19194-2-git-send-email-jepler@unpythonic.net>
In-Reply-To
<1260231763-19194-1-git-send-email-jepler@unpythonic.net>
From: Jeff Epler <jepler@unpythonic.net>
If a diff looked like
 @@
  context
 -del1
 -del2
and you wanted to stage the deletion 'del1', the generated patch wouldn't
apply because it was missing the line 'del2' converted to context, but
this line was counted in the @@-line
Signed-off-by: Jeff Epler <jepler@unpythonic.net>
---
 lib/diff.tcl |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/lib/diff.tcl b/lib/diff.tcl
index bd5d189..066755b 100644
--- a/lib/diff.tcl
+++ b/lib/diff.tcl
@@ -664,6 +664,7 @@ proc apply_line {x y} {
 		}
 		set i_l $next_l
 	}
+	set patch "$patch$pre_context"
 	set patch "@@ -$hln,$n +$hln,[eval expr $n $sign 1] @@\n$patch"
 
 	if {[catch {
-- 
1.6.3.3
Previous: jepler@unpythonic.netNext: jepler@unpythonic.net
Message 2 of 4 in “[PATCHv3 0/2] git-gui: (un)stage a range of changes at once”
  1. jepler@unpythonic.netDec 8, 2009
  2. 1/2 Fix applying a line when all following lines are deletionsjepler@unpythonic.net, Dec 8, 2009
  3. 2/2 Make it possible to apply a range of changes at oncejepler@unpythonic.net, Dec 8, 2009
  4. Shawn O. PearceJan 23, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.