Re: [PATCH] reset: add --quiet option

From: Stephen Boyd <bebarino@gmail.com>
Date: Nov 30, 2009, 01:18 UTC
Message-ID: <1259543939.5679.5.camel@swboyd-laptop>
In-Reply-To: <1259492290-21771-1-git-send-email-felipe.contreras@gmail.com>

On Sun, 2009-11-29 at 12:58 +0200, Felipe Contreras wrote:

Show 13 quoted lines

> diff --git a/builtin-reset.c b/builtin-reset.c
> index 73e6022..c0127c4 100644
> --- a/builtin-reset.c
> +++ b/builtin-reset.c
> @@ -209,7 +209,7 @@ int cmd_reset(int argc, const char **argv, const char *prefix)
>  				"reset HEAD, index and working tree", HARD),
>  		OPT_SET_INT(0, "merge", &reset_type,
>  				"reset HEAD, index and working tree", MERGE),
> -		OPT_BOOLEAN('q', NULL, &quiet,
> +		OPT_BOOLEAN('q', "quiet", &quiet,
>  				"disable showing new HEAD in hard reset and progress message"),
>  		OPT_BOOLEAN('p', "patch", &patch_mode, "select hunks interactively"),
>  		OPT_END()

Why not just OPT__QUIET? We lose the specific help string but it's possible that what quiet is silencing will change in the future.

Maybe you could move the help string to the documentation if you want to save it.