git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] submodule.c: Squelch a "use before assignment" warning

From
David Aguilar <davvid@gmail.com>
Date
Nov 20, 2009, 11:33 UTC
Message-ID
<1258716833-49974-1-git-send-email-davvid@gmail.com>
In-Reply-To
<7v8we17ha9.fsf@alter.siamese.dyndns.org>

i686-apple-darwin9-gcc-4.0.1 (GCC) 4.0.1 (Apple Inc. build 5493) compiler (and probably others) mistakenly thinks variable 'right' is used before assigned. Work around it by giving it a fake initialization.

Signed-off-by: David Aguilar <davvid@gmail.com>
---
 submodule.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/submodule.c b/submodule.c
index 461faf0..86aad65 100644
--- a/submodule.c
+++ b/submodule.c
@@ -38,7 +38,7 @@ void show_submodule_summary(FILE *f, const char *path,
 		const char *del, const char *add, const char *reset)
 {
 	struct rev_info rev;
-	struct commit *commit, *left = left, *right;
+	struct commit *commit, *left = left, *right = right;
 	struct commit_list *merge_bases, *list;
 	const char *message = NULL;
 	struct strbuf sb = STRBUF_INIT;
-- 
1.6.5.3.171.ge36e
Previous: Junio C HamanoNext: Christoph Bartoschek
Message 3 of 6 in “submodule.c: Squelch a "use before assignment" warning”
  1. submodule.c: Squelch a "use before assignment" warningDavid Aguilar, Nov 20, 2009
  2. Junio C HamanoNov 20, 2009
  3. submodule.c: Squelch a "use before assignment" warningDavid Aguilar, Nov 20, 2009
  4. Christoph BartoschekNov 21, 2009
  5. Junio C HamanoNov 22, 2009
  6. Junio C HamanoNov 22, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.