git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v4 09/12] Fix various memory leaks in transport-helper.c

From
Sverre Rabbelier <srabbelier@gmail.com>
Date
Nov 18, 2009, 01:42 UTC
Message-ID
<1258508552-20752-10-git-send-email-srabbelier@gmail.com>
In-Reply-To
<1258508552-20752-9-git-send-email-srabbelier@gmail.com>

Found with: valgrind --tool=memcheck --leak-check=full --show-reachable=yes

Signed-off-by: Sverre Rabbelier <srabbelier@gmail.com>
---
	These are mine, Daniel, please verify for saneness.
 transport-helper.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/transport-helper.c b/transport-helper.c
index da8185a..628a5ca 100644
--- a/transport-helper.c
+++ b/transport-helper.c
@@ -74,6 +74,7 @@ static struct child_process *get_helper(struct transport *transport)
 		}
 		free(refspecs);
 	}
+	strbuf_release(&buf);
 	return data->helper;
 }
 
@@ -163,6 +164,8 @@ static int fetch_with_import(struct transport *transport,
 	}
 	disconnect_helper(transport);
 	finish_command(&fastimport);
+	free(fastimport.argv);
+	fastimport.argv = NULL;
 
 	for (i = 0; i < nr_heads; i++) {
 		char *private;
@@ -176,6 +179,7 @@ static int fetch_with_import(struct transport *transport,
 		read_ref(private, posn->old_sha1);
 		free(private);
 	}
+	strbuf_release(&buf);
 	return 0;
 }
 
-- 
1.6.5.3.164.g07b0c
Previous: Sverre RabbelierNext: Sverre Rabbelier
Message 10 of 13 in “Reroll of the remote-vcs-helper series”
  1. 00/12 Reroll of the remote-vcs-helper seriesSverre Rabbelier, Nov 18, 2009
  2. 01/12 Fix memory leak in helper method for disconnectSverre Rabbelier, Nov 18, 2009
  3. 02/12 Allow programs to not depend on remotes having urlsSverre Rabbelier, Nov 18, 2009
  4. 03/12 Use a function to determine whether a remote is validSverre Rabbelier, Nov 18, 2009
  5. 04/12 Allow fetch to modify refsSverre Rabbelier, Nov 18, 2009
  6. 05/12 Add a config option for remotes to specify a foreign vcsSverre Rabbelier, Nov 18, 2009
  7. 06/12 Allow specifying the remote helper in the urlSverre Rabbelier, Nov 18, 2009
  8. 07/12 Add support for "import" helper commandSverre Rabbelier, Nov 18, 2009
  9. 08/12 Allow helper to map private ref names into normal namesSverre Rabbelier, Nov 18, 2009
  10. 09/12 Fix various memory leaks in transport-helper.cSverre Rabbelier, Nov 18, 2009
  11. 10/12 Allow helpers to report in "list" command that the ref is unchangedSverre Rabbelier, Nov 18, 2009
  12. 11/12 Basic build infrastructure for Python scriptsSverre Rabbelier, Nov 18, 2009
  13. 12/12 Add Python support library for remote helpersSverre Rabbelier, Nov 18, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.