git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] gitk: Fix error display when Tcl is too old

From
BHBernt Hansen <bernt@norang.ca>
Date
Oct 24, 2009, 20:20 UTC
Message-ID
<1256415640-10328-1-git-send-email-bernt@norang.ca>

The following patch series cleans up error message reporting when your version of Tcl is too old.

The old code checked the Tcl version first and then tried to report the error with show_error. show_error uses msgcat for translation but msgcat is not yet initialized when we are checking the Tcl version requirement.

The first patch moves the initialization of msgcat before the check for the Tcl version. This version will fail is msgcat is not available.

The second patch handles the case where the msgcat package is not available by providing a default mc procedure than just returns the argument text unchanged (essentially bypassing message text translation).

This lets us continue to use show_error as-is.
Bernt Hansen (2):
  gitk: Initialize msgcat before first use
  gitk: Provide a default mc function if msgcat is not available
 gitk |   46 ++++++++++++++++++++++++++--------------------
 1 files changed, 26 insertions(+), 20 deletions(-)
Next: Bernt Hansen
Message 1 of 8 in “gitk: Fix error display when Tcl is too old”
  1. 0/2 gitk: Fix error display when Tcl is too oldBernt Hansen, Oct 24, 2009
  2. 1/2 gitk: Initialize msgcat before first useBernt Hansen, Oct 24, 2009
  3. Pat ThoytsOct 31, 2009
  4. Bernt HansenNov 1, 2009
  5. Skip translation of wrong Tcl version textBernt Hansen, Nov 2, 2009
  6. Paul MackerrasNov 3, 2009
  7. 2/2 gitk: Provide a default mc function if msgcat is not availableBernt Hansen, Oct 24, 2009
  8. Junio C HamanoOct 24, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.