Re: [PATCH 5/6 (v4)] full integration of rev-cache into git, completed test suite

From: Sam Vilain <sam@vilain.net>
Date: Sep 7, 2009, 21:06 UTC
Message-ID: <1252357564.5969.4.camel@maia.lan>
In-Reply-To: <op.uzv4covmtdk399@sirnot.private>

On Mon, 2009-09-07 at 16:11 +0200, Nick Edelen wrote:

> This last patch

^^ You don't need to write comments like "This patch"; in the history such words are meaningless.

> provides a working integration of rev-cache into the revision 
> walker, along with some touch-ups:
>  - integration into revision walker and list-objects
>  - tweak of object generation

"tweak" ?

>  - more fluid handling of damaged cache slices

What does this mean?

Show 16 quoted lines

>  - numerous tests for both features from the previous patch, and the 
> integration's integrity
> 'Integration' is rather broad -- a more detailed description follows for each 
> aspect:
>  - rev-cache
> the traversal mechanism is updated to handle many of the non-prune options 
> rev-list does (date limiting, slop-handling, etc.), and is adjusted to allow 
> for non-fatal cache-traversal failures.
> 
>  - revision walker
> both limited and unlimited traversal attempt to use the cache when possible, 
> smoothly falling back if it's not.
> 
>  - list-objects
> object listing does not recurse into cached trees, and has been adjusted to 
> guarantee commit-tag-tree-blob ordering.

This is quite a long commit message. Is the above detail all useful? Can it be split into one patch for each of the above integrations?

> Signed-off-by: Nick Edelen <sirnot@gmail.com>

Sam