git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v5a 6/6] fast-import: test the new option command

From
Sverre Rabbelier <srabbelier@gmail.com>
Date
Aug 27, 2009, 18:40 UTC
Message-ID
<1251398431-12461-7-git-send-email-srabbelier@gmail.com>
In-Reply-To
<1251398431-12461-6-git-send-email-srabbelier@gmail.com>

Test three options (quiet and import/export-marks) and verify that the commandline options override these.

Signed-off-by: Sverre Rabbelier <srabbelier@gmail.com>
---
	Only difference from v4 is that it is rebased and a new test to
	verify that 'feature git-options' is now accepted.
 t/t9300-fast-import.sh |   68 +++++++++++++++++++++++++++++++++++++++++++++++-
 1 files changed, 67 insertions(+), 1 deletions(-)
diff --git a/t/t9300-fast-import.sh b/t/t9300-fast-import.sh
index a5b9b38..1fbfc5e 100755
--- a/t/t9300-fast-import.sh
+++ b/t/t9300-fast-import.sh
@@ -1089,7 +1089,7 @@ test_expect_success 'P: fail on blob mark in gitlink' '
     test_must_fail git fast-import <input'
 
 ###
-### series Q (feature)
+### series Q (feature and option)
 ###
 
 cat >input <<EOF
@@ -1108,4 +1108,70 @@ test_expect_success 'Q: supported feature is accepted' '
 	git fast-import <input
 '
 
+cat >input << EOF
+feature git-options
+option quiet
+blob
+data 3
+hi
+
+EOF
+
+touch empty
+
+test_expect_success 'Q: quiet option results in no stats being output' '
+    cat input | git fast-import 2> output &&
+    test_cmp empty output
+'
+
+cat >input << EOF
+feature git-options
+option export-marks=git.marks
+blob
+mark :1
+data 3
+hi
+
+EOF
+
+test_expect_success \
+    'Q: export-marks option results in a marks file being created' \
+    'cat input | git fast-import &&
+    grep :1 git.marks'
+
+test_expect_success \
+    'Q: export-marks options can be overriden by commandline options' \
+    'cat input | git fast-import --export-marks=other.marks &&
+    grep :1 other.marks'
+
+cat >input << EOF
+feature git-options
+option import-marks=marks.out
+option export-marks=marks.new
+EOF
+
+test_expect_success \
+    'Q: import to output marks works without any content' \
+    'cat input | git fast-import &&
+    test_cmp marks.out marks.new'
+
+cat >input <<EOF
+feature git-options
+option import-marks=nonexistant.marks
+option export-marks=marks.new
+EOF
+
+test_expect_success \
+    'Q: import marks uses the commandline marks file when the stream specifies one' \
+    'cat input | git fast-import --import-marks=marks.out &&
+    test_cmp marks.out marks.new'
+
+cat >input <<EOF
+feature git-options
+EOF
+
+test_expect_success 'Q: feature option is accepted' '
+	git fast-import <input
+'
+
 test_done
-- 
1.6.4.122.g6ffd7
Previous: Sverre RabbelierNext: Teemu Likonen
Message 7 of 9 in “add new feature and option command”
  1. 0/6 add new feature and option commandSverre Rabbelier, Aug 27, 2009
  2. 1/6 fast-import: put option parsing code in seperate functionsSverre Rabbelier, Aug 27, 2009
  3. 2/6 fast-import: put marks reading in it's own functionSverre Rabbelier, Aug 27, 2009
  4. 3/6 fast-import: add feature commandSverre Rabbelier, Aug 27, 2009
  5. 4/6 fast-import: test the new feature commandSverre Rabbelier, Aug 27, 2009
  6. 5/6 fast-import: add option commandSverre Rabbelier, Aug 27, 2009
  7. 6/6 fast-import: test the new option commandSverre Rabbelier, Aug 27, 2009
  8. Teemu LikonenAug 27, 2009
  9. Sverre RabbelierAug 27, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.