git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 05/12] Place __stdcall between return value and function name

From
Frank Li <lznuaa@gmail.com>
Date
Aug 19, 2009, 15:52 UTC
Message-ID
<1250697167-5536-5-git-send-email-lznuaa@gmail.com>
In-Reply-To
<1250697167-5536-4-git-send-email-lznuaa@gmail.com>

MSVC require __stdcall is between return value and function name. ALL Win32 API definition is as TYPE WINAPI function name

Signed-off-by: Frank Li <lznuaa@gmail.com>
---
 compat/mingw.c |    4 ++--
 run-command.c  |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/compat/mingw.c b/compat/mingw.c
index d5fa0ed..c938f0a 100644
--- a/compat/mingw.c
+++ b/compat/mingw.c
@@ -1017,7 +1017,7 @@ static sig_handler_t timer_fn = SIG_DFL;
  * length to call the signal handler.
  */
 
-static __stdcall unsigned ticktack(void *dummy)
+static unsigned __stdcall ticktack(void *dummy)
 {
 	while (WaitForSingleObject(timer_event, timer_interval) == WAIT_TIMEOUT) {
 		if (timer_fn == SIG_DFL)
@@ -1146,7 +1146,7 @@ void mingw_open_html(const char *unixpath)
 
 int link(const char *oldpath, const char *newpath)
 {
-	typedef BOOL WINAPI (*T)(const char*, const char*, LPSECURITY_ATTRIBUTES);
+	typedef BOOL (WINAPI *T)(const char*, const char*, LPSECURITY_ATTRIBUTES);
 	static T create_hard_link = NULL;
 	if (!create_hard_link) {
 		create_hard_link = (T) GetProcAddress(
diff --git a/run-command.c b/run-command.c
index d0833f8..62bea19 100644
--- a/run-command.c
+++ b/run-command.c
@@ -295,7 +295,7 @@ int run_command_v_opt_cd_env(const char **argv, int opt, const char *dir, const
 }
 
 #ifdef WIN32
-static __stdcall unsigned run_thread(void *data)
+static unsigned __stdcall run_thread(void *data)
 {
 	struct async *async = data;
 	return async->proc(async->fd_for_proc, async->data);
-- 
1.6.4.msysgit.0
Previous: Frank LiNext: Frank Li
Message 5 of 12 in “Avoid declaration after instruction”
  1. 01/12 Avoid declaration after instructionFrank Li, Aug 19, 2009
  2. 02/12 Define SNPRINTF_SIZE_CORR=1 for Microsoft Visual C++Frank Li, Aug 19, 2009
  3. 03/12 Using macro WIN32 replace __MINGW32_ at Windows special handler The code which is conditional on MinGW32 is actually conditional on Windows. Use WIN32 macro will share both MINGW32 and MSVC environment.Frank Li, Aug 19, 2009
  4. 04/12 mingw.c: Use the O_BINARY flag to open filesFrank Li, Aug 19, 2009
  5. 05/12 Place __stdcall between return value and function nameFrank Li, Aug 19, 2009
  6. 06/12 Add _MSC_VER in porting head file git-compat-util.hFrank Li, Aug 19, 2009
  7. 07/12 Add Unix header files to build git at MSVC.Frank Li, Aug 19, 2009
  8. 08/12 Add MSVC porting files.Frank Li, Aug 19, 2009
  9. 09/12 Don't include windows.h at winansi.c at MSVC buildFrank Li, Aug 19, 2009
  10. 10/12 Fix errcode have defined as int at MSVCFrank Li, Aug 19, 2009
  11. 11/12 Add MSVC Project fileFrank Li, Aug 19, 2009
  12. Erik Faye-LundAug 19, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.