Re: [PATCH v2 4/5] pack-objects: support excluded-open packs with --stdin-packs
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Mar 26, 2026, 20:48 UTC
- Message-ID
- <124c202b-9641-4445-bb38-9cd70c836844@gmail.com>
- In-Reply-To
- <e028dfbc9fb5f53d706b1cfb8ee0759b6f1c4575.1774482701.git.me@ttaylorr.com>
On 3/25/2026 7:51 PM, Taylor Blau wrote:
Show 7 quoted lines
> struct stdin_pack_info {
> struct packed_git *p;
> enum {
> STDIN_PACK_INCLUDE = (1<<0),
> STDIN_PACK_EXCLUDE_CLOSED = (1<<1),
> + STDIN_PACK_EXCLUDE_OPEN = (1<<2),
> } kind;Especially because we're extending this, I feel more confident that this would improve by being a named enum. Perhaps these modes could get comments explaining their differences and how they might operate in combination.
Show 6 quoted lines
> if (!*key) > continue; > - if (*key == '^') > + if (*key == '^' || > + (*key == '!' && mode == STDIN_PACKS_MODE_FOLLOW)) > key++;
This part is getting more complicated, giving potentially more reason to start with a single branching point in patch 2.
Show 7 quoted lines
> diff --git a/t/t5331-pack-objects-stdin.sh b/t/t5331-pack-objects-stdin.sh
> index 7eb79bc2cdb..c74b5861af3 100755
> --- a/t/t5331-pack-objects-stdin.sh
> +++ b/t/t5331-pack-objects-stdin.sh
> @@ -415,4 +415,109 @@ test_expect_success '--stdin-packs=follow tolerates missing commits' '
> stdin_packs__follow_with_only HEAD HEAD^{tree}
> 'I see that this isn't yet the fix that turns failure into success. I look forward to seeing that changeover.
Thanks, -Stolee