git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add --allow-eof-whitelines to git-apply while still doing whitespace trailing-space fixing.

From
Thell Fowler <tbfowler4@gmail.com>
Date
Aug 5, 2009, 00:15 UTC
Message-ID
<1249431338.2774.59.camel@GWPortableVCS>
In-Reply-To
<20090805061519.6117@nanako3.lavabit.com>
On Wed, 2009-08-05 at 06:15 +0900, Nanako Shiraishi wrote:
Show 14 quoted lines
> Quoting Thell Fowler <tbfowler4@gmail.com>
> 
> >   - Added --allow-eof-whitelines to git apply to short-circuit removal
> > of new empty lines when tailing-space is set.
> >   - Added pass-through to apply from git-am.sh
> >   - Added pass-through to git-am from git-rebase.sh
> >   - Added the auto-completion entries.
> >
> > Signed-off-by: TBFowler <thell@almostautomated.com>
> 
> I like this new feature. However, this topic came up last week, and Junio said that whitespace checking should be controlled with the attributes mechanism.
> 
> http://thread.gmane.org/gmane.comp.version-control.git/124113/focus=124138
> 

Seemed that the issue/resolution was still open for discussion. http://thread.gmane.org/gmane.comp.version-control.git/124113/focus=124138

Should this be re-done as a whitespace attribute?
Show 11 quoted lines
> Please do not talk "I did this, I did that" in your proposed commit log
> message.  From Documentation/SubmittingPatches:
> 
> 	- the body should provide a meaningful commit message, which:
> 		- uses the imperative, present tense: "change",
> 		  not "changed" or "changes".
> 		- includes motivation for the change, and contrasts
> 		  its implementation with previous behaviour
> 
> In other words, the messages are often written as if you are giving an order to the program to correct itself.
> 
Got it. ...'giving an order'...  and the motivation; should be easy to remember.

Thank you for the feedback and instruction. Thell

Previous: Nanako Shiraishi
Message 3 of 3 in “Add --allow-eof-whitelines to git-apply while still doing whitespace trailing-space fixing.”
  1. Add --allow-eof-whitelines to git-apply while still doing whitespace trailing-space fixing.Thell Fowler, Aug 1, 2009
  2. Nanako ShiraishiAug 4, 2009
  3. Thell FowlerAug 5, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.