git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[JGIT PATCH 2/5] Allow RemoteConfig.getAllRemoteConfigs on any Config object

From
Shawn O. Pearce <spearce@spearce.org>
Date
Jul 29, 2009, 15:50 UTC
Message-ID
<1248882627-7285-3-git-send-email-spearce@spearce.org>
In-Reply-To
<1248882627-7285-2-git-send-email-spearce@spearce.org>

Back in 07c8dc6e94729ff4104f0a1c815dd81f3e71c562 I changed the RemoteConfig class to accept any Config object, but its static getAllRemoteConfigs() utility method was missed and still used a RepositoryConfig. It should take any Config.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 .../org/spearce/jgit/transport/RemoteConfig.java   |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/org.spearce.jgit/src/org/spearce/jgit/transport/RemoteConfig.java b/org.spearce.jgit/src/org/spearce/jgit/transport/RemoteConfig.java
index ca84acf..dd7a50c 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/transport/RemoteConfig.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/transport/RemoteConfig.java
@@ -44,7 +44,6 @@
 import java.util.List;
 
 import org.spearce.jgit.lib.Config;
-import org.spearce.jgit.lib.RepositoryConfig;
 
 /**
  * A remembered remote repository, including URLs and RefSpecs.
@@ -96,8 +95,8 @@
 	 * @throws URISyntaxException
 	 *             one of the URIs within the remote's configuration is invalid.
 	 */
-	public static List<RemoteConfig> getAllRemoteConfigs(
-			final RepositoryConfig rc) throws URISyntaxException {
+	public static List<RemoteConfig> getAllRemoteConfigs(final Config rc)
+			throws URISyntaxException {
 		final List<String> names = new ArrayList<String>(rc
 				.getSubsections(SECTION));
 		Collections.sort(names);
-- 
1.6.4.rc3.201.gd9d59
Previous: Shawn O. PearceNext: Shawn O. Pearce
Message 3 of 6 in “Some minor bug fixes”
  1. 0/5 Some minor bug fixesShawn O. Pearce, Jul 29, 2009
  2. 1/5 Don't dispose of RevFlag used to advertise objects in ReceivePackShawn O. Pearce, Jul 29, 2009
  3. 2/5 Allow RemoteConfig.getAllRemoteConfigs on any Config objectShawn O. Pearce, Jul 29, 2009
  4. 3/5 Add ConfigInvalidException constructor to take ThrowableShawn O. Pearce, Jul 29, 2009
  5. 4/5 Add no fallback constructor to FileBasedConfigShawn O. Pearce, Jul 29, 2009
  6. 5/5 Include the file path when FileBasedConfig.load throws an exceptionShawn O. Pearce, Jul 29, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.