Re: [ANNOUNCE] GIT 1.6.4-rc2
- From
- Mattias Nissler <mattias.nissler@gmx.de>
- Date
- Jul 25, 2009, 20:16 UTC
- Message-ID
- <1248553018.4593.15.camel@kea>
- In-Reply-To
- <20090725192230.GA11510@dcvr.yhbt.net>
On Sat, 2009-07-25 at 12:22 -0700, Eric Wong wrote:
Show 24 quoted lines
> Mattias Nissler <mattias.nissler@gmx.de> wrote:
> > Maybe we should rather try to detect whether we have read access to the
> > repository root and adjust behaviour accordingly? Or at least print a
> > warning when cloning restricted multi-branch repos, since this just
> > fails silently (doesn't pick up any branches) when you have minimize_url
> > enabled.
>
> We actually try that in Git::SVN::Ra::minimize_url:
>
> sub minimize_url {
> my ($self) = @_;
> return $self->{url} if ($self->{url} eq $self->{repos_root});
> my $url = $self->{repos_root};
> my @components = split(m!/!, $self->{svn_path});
> my $c = '';
> do {
> $url .= "/$c" if length $c;
> eval { (ref $self)->new($url)->get_latest_revnum };
> } while ($@ && ($c = shift @components));
> $url;
> }
>
> Maybe get_latest_revnum() isn't strong enough of a check for
> certain setups and get_log() needs to be used instead?Well, I simply wasn't aware of this. I've just retried and it turns out latest git.git works perfectly for me in both restricted and non-restricted setups. Great work!
Mattias