git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[JGIT PATCH 03/11] Don't retry ".git" suffix in daemon if already tried

From
Shawn O. Pearce <spearce@spearce.org>
Date
Jul 11, 2009, 20:19 UTC
Message-ID
<1247343566-19025-4-git-send-email-spearce@spearce.org>
In-Reply-To
<1247343566-19025-3-git-send-email-spearce@spearce.org>

If the name we already tried ended in ".git", don't append ".git" (creating "foo.git.git") and search the map again. Instead the names are normalized to always end with ".git", and ".git" is put on the end if it is not present in the user request.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 .../src/org/spearce/jgit/transport/Daemon.java     |   10 ++++------
 1 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/org.spearce.jgit/src/org/spearce/jgit/transport/Daemon.java b/org.spearce.jgit/src/org/spearce/jgit/transport/Daemon.java
index 7b4c138..f55e049 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/transport/Daemon.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/transport/Daemon.java
@@ -195,7 +195,9 @@ public void setExportAll(final boolean export) {
 	 * @param db
 	 *            the repository instance.
 	 */
-	public void exportRepository(final String name, final Repository db) {
+	public void exportRepository(String name, final Repository db) {
+		if (!name.endsWith(".git"))
+			name = name + ".git";
 		exports.put(name, db);
 	}
 
@@ -347,11 +349,7 @@ Repository openRepository(String name) {
 		name = name.substring(1);
 
 		Repository db;
-		db = exports.get(name);
-		if (db != null)
-			return db;
-
-		db = exports.get(name + ".git");
+		db = exports.get(name.endsWith(".git") ? name : name + ".git");
 		if (db != null)
 			return db;
 
-- 
1.6.4.rc0.117.g28cb
Previous: Shawn O. PearceNext: Shawn O. Pearce
Message 4 of 14 in “Repository instance caching”
  1. 00/11 Repository instance cachingShawn O. Pearce, Jul 11, 2009
  2. 01/11 Change Daemon to use concurrent collections for exported repositoriesShawn O. Pearce, Jul 11, 2009
  3. 02/11 Make Daemon's exportAll check not require synchronizationShawn O. Pearce, Jul 11, 2009
  4. 03/11 Don't retry ".git" suffix in daemon if already triedShawn O. Pearce, Jul 11, 2009
  5. 04/11 Refactor ref advertisement code from server implementationsShawn O. Pearce, Jul 11, 2009
  6. 05/11 Don't advertise HEAD from ReceivePackShawn O. Pearce, Jul 11, 2009
  7. 06/11 Add a use reference counter to RepositoryShawn O. Pearce, Jul 11, 2009
  8. 07/11 Introduce RepositoryCache to cache handles of Repository objectsShawn O. Pearce, Jul 11, 2009
  9. 08/11 Change Daemon to use RepositoryCacheShawn O. Pearce, Jul 11, 2009
  10. 09/11 Expose the Repository's ObjectDatabase objectShawn O. Pearce, Jul 11, 2009
  11. 10/11 Use cached Repository instances when resolving alternatesShawn O. Pearce, Jul 11, 2009
  12. 11/11 Send .have lines in ReceivePack for alternate repositoriesShawn O. Pearce, Jul 11, 2009
  13. Robin RosenbergJul 21, 2009
  14. Shawn O. PearceJul 21, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.