[PATCH] completion: __git_config_get_set_variables() handle values with spaces
- From
Stephen Boyd <bebarino@gmail.com>
- Date
- Jun 30, 2009, 05:08 UTC
- Message-ID
- <1246338518-9030-1-git-send-email-bebarino@gmail.com>
Commit 0065236 (bash completion: complete variable names for "git config" with options 2009-05-08) implemented its config variable search wrong. When a config contains a value with a space and a period (.) in it, completion erroneously thinks that line in the configuration is multiple config variables.
For example
$ cat .git/config format.cc = Junio C Hamano <gitster@pobox.com>
$ git config --unset <TAB> format.cc <gitster@pobox.com>
Instead of using a for loop splitting across spaces, pipe each line to a while read loop and beef up the case statement to match only 'config.variable=value'.
Signed-off-by: Stephen Boyd <bebarino@gmail.com> --- contrib/completion/git-completion.bash | 11 ++++++----- 1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index b60cb68..d676f9d 100755 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -1357,11 +1357,12 @@ __git_config_get_set_variables () c=$((--c)) done - for i in $(git --git-dir="$(__gitdir)" config $config_file --list \ - 2>/dev/null); do - case "$i" in - *.*) - echo "${i/=*/}" + git --git-dir="$(__gitdir)" config $config_file --list 2>/dev/null | + while read line + do + case "$line" in + *.*=*) + echo "${line/=*/}" ;; esac done
-- 1.6.3.3.353.g4f2b1