git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv3 1/7] fast-export: Set revs.topo_order before calling setup_revisions

From
newren@gmail.com <newren@gmail.com>
Date
Jun 26, 2009, 04:48 UTC
Message-ID
<1245991713-12782-2-git-send-email-newren@gmail.com>
In-Reply-To
<1245991713-12782-1-git-send-email-newren@gmail.com>
From: Elijah Newren <newren@gmail.com>

setup_revisions sets a variety of flags based on the setting of other flags, such as setting the limited flag when topo_order is set. To avoid circumventing any invariants created by setup_revisions, we set revs.topo_order before calling it rather than after.

Signed-off-by: Elijah Newren <newren@gmail.com>
---
This patch is new since the last series.
 builtin-fast-export.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/builtin-fast-export.c b/builtin-fast-export.c
index 6cef810..e0cfa60 100644
--- a/builtin-fast-export.c
+++ b/builtin-fast-export.c
@@ -514,6 +514,7 @@ int cmd_fast_export(int argc, const char **argv, const char *prefix)
 	git_config(git_default_config, NULL);
 
 	init_revisions(&revs, prefix);
+	revs.topo_order = 1;
 	argc = setup_revisions(argc, argv, &revs, NULL);
 	argc = parse_options(argc, argv, prefix, options, fast_export_usage, 0);
 	if (argc > 1)
@@ -524,7 +525,6 @@ int cmd_fast_export(int argc, const char **argv, const char *prefix)
 
 	get_tags_and_duplicates(&revs.pending, &extra_refs);
 
-	revs.topo_order = 1;
 	if (prepare_revision_walk(&revs))
 		die("revision walk setup failed");
 	revs.diffopt.format_callback = show_filemodify;
-- 
1.6.3.2.323.geb889
Previous: newren@gmail.comNext: newren@gmail.com
Message 2 of 8 in “A few fast export fixups -- round 3”
  1. newren@gmail.comJun 26, 2009
  2. 1/7 fast-export: Set revs.topo_order before calling setup_revisionsnewren@gmail.com, Jun 26, 2009
  3. 2/7 fast-export: Omit tags that tag treesnewren@gmail.com, Jun 26, 2009
  4. 3/7 fast-export: Make sure we show actual ref names instead of "(null)"newren@gmail.com, Jun 26, 2009
  5. 4/7 fast-export: Do parent rewriting to avoid dropping relevant commitsnewren@gmail.com, Jun 26, 2009
  6. 5/7 fast-export: Add a --tag-of-filtered-object option for newly dangling tagsnewren@gmail.com, Jun 26, 2009
  7. 6/7 Add new fast-export testcasesnewren@gmail.com, Jun 26, 2009
  8. 7/7 fast-export: Document the fact that git-rev-list arguments are acceptednewren@gmail.com, Jun 26, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.