[JGIT PATCH] Don't log TransportGitSsh error stream to JVM stderr
- From
Shawn O. Pearce <spearce@spearce.org>
- Date
- Jun 7, 2009, 22:31 UTC
- Message-ID
- <1244413884-17241-1-git-send-email-spearce@spearce.org>
This is an API function, not a user interface routine. We should not be printing messages from the remote side to our console. Instead we should buffer them, and allow a TransportException to be thrown which contains the message data. Higher level user interface routines can then catch that exception, and display the message, if any, in a form that is appropriate to the context.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org> --- .../spearce/jgit/transport/TransportGitSsh.java | 7 ++----- 1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/org.spearce.jgit/src/org/spearce/jgit/transport/TransportGitSsh.java b/org.spearce.jgit/src/org/spearce/jgit/transport/TransportGitSsh.java index 2e9e0be..de72d02 100644 --- a/org.spearce.jgit/src/org/spearce/jgit/transport/TransportGitSsh.java +++ b/org.spearce.jgit/src/org/spearce/jgit/transport/TransportGitSsh.java @@ -166,17 +166,14 @@ public String toString() { @Override public void write(final int b) throws IOException { if (b == '\r') { - System.err.print('\r'); return; } sb.append((char) b); if (b == '\n') { - final String line = sb.toString(); - System.err.print(line); - all.append(line); - sb = new StringBuilder(); + all.append(sb); + sb.setLength(0); } } };
-- 1.6.3.2.322.g117de