git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2] symlinks.c: small style cleanup

From
KBKjetil Barvik <barvik@broadpark.no>
Date
Jun 7, 2009, 14:43 UTC
Message-ID
<1244385836-8540-1-git-send-email-barvik@broadpark.no>

Remove some unnecessary "return;"-statements at the end of "void foo()"-functions.

Signed-off-by: Kjetil Barvik <barvik@broadpark.no>
---
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 9 quoted lines
> Hi,
>
> On Sun, 7 Jun 2009, Kjetil Barvik wrote:
>
>> Add {}-braces around an else-part, where the if-part already has
>> {}-braces.
>
> This is the wrong way round.  We prefer _not_ to add unnecessary
> braces, but do tolerate them from time to time.
  OK.  Have taken away that part of the patch in this verson (v2).
  -- kjetil
 symlinks.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/symlinks.c b/symlinks.c
index 1d6b35b..64c8cd3 100644
--- a/symlinks.c
+++ b/symlinks.c
@@ -263,7 +263,6 @@ static void do_remove_scheduled_dirs(int new_len)
 			 removal.path[removal.len] != '/');
 	}
 	removal.len = new_len;
-	return;
 }
 
 void schedule_dir_for_removal(const char *name, int len)
@@ -296,11 +295,9 @@ void schedule_dir_for_removal(const char *name, int len)
 		       last_slash - match_len);
 		removal.len = last_slash;
 	}
-	return;
 }
 
 void remove_scheduled_dirs(void)
 {
 	do_remove_scheduled_dirs(0);
-	return;
 }
-- 
1.6.3.2.277.gd10543
Message 1 of 1 in “symlinks.c: small style cleanup”
  1. symlinks.c: small style cleanupKjetil Barvik, Jun 7, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.