Re: [PATCH 0/7] [GSoC2009] Revision cache / git-daemon caching plan

From: Sam Vilain <sam@vilain.net>
Date: Jun 7, 2009, 04:01 UTC
Message-ID: <1244347301.9843.52.camel@maia.lan>
In-Reply-To: <m34ouu7h70.fsf@localhost.localdomain>

On Fri, 2009-06-05 at 09:56 -0700, Jakub Narebski wrote:

Show 14 quoted lines

> > The plan is to aim for one of these API milestones completed per week.
> > When complete, each commit will contain tests for the level of cache
> > that it delivers.  Later milestones include joining the dots -
> > integrating with the 'rev-list' machinery and most importantly,
> > 'pack-objects'.
> 
> I like this sharing not only completed code, but plans, designs (and
> status reports) with Git Development Community (i.e. git mailing
> list).  I like this very much.
> 
> 
> I'd like to ask if there any results of profiling git server
> (git-daemon) code: how much is spend on object enumeration this GSoC
> project tries to make faster by the means of caching?

No, but you're not the first to ask - I'll research this and include profiling of it (obviously needing to descend into stages taken by pack-objects/receive-packs, as Nicholas points out) in the next update I send out.

> Are there prepared benchmarks and tests to check if the code gives
> correct results, and to measure improvements brought by caching?
> Would it be possible to get some real-life statistics of git-daemon
> usage, so that you optimize against real scenarios?

In terms of correct results - that will come down to the test cases which are written for it, and possibly extending the existing test cases eg t5500-fetch-pack.sh

> I wish you good work on git-daemon caching...

Thanks!

Sam.