git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[JGIT PATCH 0/7] Misc. transport cleanup

From
Shawn O. Pearce <spearce@spearce.org>
Date
Jun 4, 2009, 21:43 UTC
Message-ID
<1244151843-26954-1-git-send-email-spearce@spearce.org>

After the dicussions with Jakub Narebski I realized we aren't as lenient in parsing hex strings as C Git is. So make it so.

I also added some tests for the lower level parts of the native protocol, the pkt-line format. Testing is still far from complete in this area of the code, but we're slightly better now.

Shawn O. Pearce (7):
  Move hex parsing functions to RawParseUtil, accept upper case
  Disambiguate pkt-line "0000" from "0004"
  Move PacketLineIn hex parsing to RawParseUtils
  Add tests for RawParseUtil's hex string parsing
  Add tests for PacketLineIn
  Add tests for PacketLineOut
  Add tests for SideBandOutputStream
 .../tst/org/spearce/jgit/lib/T0001_ObjectId.java   |   10 +-
 .../spearce/jgit/transport/PacketLineInTest.java   |  262 ++++++++++++++++++++
 .../spearce/jgit/transport/PacketLineOutTest.java  |  175 +++++++++++++
 .../jgit/transport/SideBandOutputStreamTest.java   |  146 +++++++++++
 .../jgit/util/RawParseUtils_HexParseTest.java      |  158 ++++++++++++
 .../org/spearce/jgit/lib/AbbreviatedObjectId.java  |    8 +-
 .../src/org/spearce/jgit/lib/AnyObjectId.java      |   36 ---
 .../src/org/spearce/jgit/lib/MutableObjectId.java  |   11 +-
 .../src/org/spearce/jgit/lib/ObjectId.java         |   19 +-
 .../spearce/jgit/transport/BasePackConnection.java |    5 +-
 .../jgit/transport/BasePackPushConnection.java     |    2 +-
 .../org/spearce/jgit/transport/DaemonClient.java   |    5 +-
 .../org/spearce/jgit/transport/PacketLineIn.java   |   44 +---
 .../org/spearce/jgit/transport/ReceivePack.java    |    6 +-
 .../src/org/spearce/jgit/transport/UploadPack.java |    4 +-
 .../src/org/spearce/jgit/util/RawParseUtils.java   |  110 ++++++++-
 16 files changed, 893 insertions(+), 108 deletions(-)
 create mode 100644 org.spearce.jgit.test/tst/org/spearce/jgit/transport/PacketLineInTest.java
 create mode 100644 org.spearce.jgit.test/tst/org/spearce/jgit/transport/PacketLineOutTest.java
 create mode 100644 org.spearce.jgit.test/tst/org/spearce/jgit/transport/SideBandOutputStreamTest.java
 create mode 100644 org.spearce.jgit.test/tst/org/spearce/jgit/util/RawParseUtils_HexParseTest.java
Next: Shawn O. Pearce
Message 1 of 9 in “Misc. transport cleanup”
  1. 0/7 Misc. transport cleanupShawn O. Pearce, Jun 4, 2009
  2. 1/7 Move hex parsing functions to RawParseUtil, accept upper caseShawn O. Pearce, Jun 4, 2009
  3. 2/7 Disambiguate pkt-line "0000" from "0004"Shawn O. Pearce, Jun 4, 2009
  4. 3/7 Move PacketLineIn hex parsing to RawParseUtilsShawn O. Pearce, Jun 4, 2009
  5. 4/7 Add tests for RawParseUtil's hex string parsingShawn O. Pearce, Jun 4, 2009
  6. 5/7 Add tests for PacketLineInShawn O. Pearce, Jun 4, 2009
  7. 6/7 Add tests for PacketLineOutShawn O. Pearce, Jun 4, 2009
  8. 7/7 Add tests for SideBandOutputStreamShawn O. Pearce, Jun 4, 2009
  9. Shawn O. PearceJun 15, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.