git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/5] MinGW: Scan for \r in addition to \n when reading shbang lines

From
Steffen Prohaska <prohaska@zib.de>
Date
May 23, 2009, 08:04 UTC
Message-ID
<1243065891-13270-2-git-send-email-prohaska@zib.de>
In-Reply-To
<1243065891-13270-1-git-send-email-prohaska@zib.de>
From: Peter Harris <git@peter.is-a-geek.org>
\r is common on Windows, so we should handle it gracefully.
Signed-off-by: Steffen Prohaska <prohaska@zib.de>
---
 compat/mingw.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/compat/mingw.c b/compat/mingw.c
index cdeda1d..b723c4d 100644
--- a/compat/mingw.c
+++ b/compat/mingw.c
@@ -525,8 +525,8 @@ static const char *parse_interpreter(const char *cmd)
 	if (buf[0] != '#' || buf[1] != '!')
 		return NULL;
 	buf[n] = '\0';
-	p = strchr(buf, '\n');
-	if (!p)
+	p = buf + strcspn(buf, "\r\n");
+	if (!*p)
 		return NULL;
 
 	*p = '\0';
-- 
1.6.3.1.54.g99dd
Previous: Steffen ProhaskaNext: Steffen Prohaska
Message 2 of 6 in “A few minor MinGW changes”
  1. 0/5 A few minor MinGW changesSteffen Prohaska, May 23, 2009
  2. 1/5 MinGW: Scan for \r in addition to \n when reading shbang linesSteffen Prohaska, May 23, 2009
  3. 2/5 MinGW: the path separator to split GITPERLLIB is ';' on Win32Steffen Prohaska, May 23, 2009
  4. 3/5 MinGW: use POSIX signature of waitpid()Steffen Prohaska, May 23, 2009
  5. 4/5 MinGW: Add a simple getpass()Steffen Prohaska, May 23, 2009
  6. 5/5 MinGW: Fix compiler warning in merge-recursiveSteffen Prohaska, May 23, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.