[EGIT PATCH] Skip unnecessary test in ObjectChecker
- From
Robin Rosenberg <robin.rosenberg@dewire.com>
- Date
- Apr 26, 2009, 14:36 UTC
- Message-ID
- <1240756575-24113-1-git-send-email-robin.rosenberg@dewire.com>
The check for duplicate names unnecessarily checks for end of buffer. Previous tests took care of that.
Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com> --- .../src/org/spearce/jgit/lib/ObjectChecker.java | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/ObjectChecker.java b/org.spearce.jgit/src/org/spearce/jgit/lib/ObjectChecker.java index 75e3c77..5a3da39 100644 --- a/org.spearce.jgit/src/org/spearce/jgit/lib/ObjectChecker.java +++ b/org.spearce.jgit/src/org/spearce/jgit/lib/ObjectChecker.java @@ -254,14 +254,10 @@ private static boolean duplicateName(final byte[] raw, final int nextNamePos = nextPtr; for (;;) { - if (nextPtr == sz) - return false; final byte c = raw[nextPtr++]; if (c == 0) break; } - if (nextNamePos + 1 == nextPtr) - return false; final int cmp = pathCompare(raw, thisNamePos, thisNameEnd, FileMode.TREE.getBits(), nextNamePos, nextPtr - 1, nextMode);
-- 1.6.3.rc2.1.g4f9e8.dirty