git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] Localizing temporary variables

From
andy@petdance.com <andy@petdance.com>
Date
Apr 22, 2009, 06:00 UTC
Message-ID
<1240380037-24785-1-git-send-email-andy@petdance.com>
From: Andy Lester <andy@petdance.com>
---
 builtin-show-ref.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/builtin-show-ref.c b/builtin-show-ref.c
index dc76c50..3dc8fe2 100644
--- a/builtin-show-ref.c
+++ b/builtin-show-ref.c
@@ -22,8 +22,6 @@ static void show_one(const char *refname, const unsigned char *sha1)
 
 static int show_ref(const char *refname, const unsigned char *sha1, int flag, void *cbdata)
 {
-	struct object *obj;
-	const char *hex;
 	unsigned char peeled[20];
 
 	if (tags_only || heads_only) {
@@ -75,16 +73,19 @@ match:
 
 	if ((flag & REF_ISPACKED) && !peel_ref(refname, peeled)) {
 		if (!is_null_sha1(peeled)) {
+			const char *hex;
 			hex = find_unique_abbrev(peeled, abbrev);
 			printf("%s %s^{}\n", hex, refname);
 		}
 	}
 	else {
+		struct object *obj;
 		obj = parse_object(sha1);
 		if (!obj)
 			die("git show-ref: bad ref %s (%s)", refname,
 			    sha1_to_hex(sha1));
 		if (obj->type == OBJ_TAG) {
+			const char *hex;
 			obj = deref_tag(obj, refname, 0);
 			if (!obj)
 				die("git show-ref: bad tag at ref %s (%s)", refname,
-- 
1.6.2.4
Next: andy@petdance.com
Message 1 of 2 in “Localizing temporary variables”
  1. 1/2 Localizing temporary variablesandy@petdance.com, Apr 22, 2009
  2. 2/2 Applying const to arg for rev_is_head(). Localized a work variable.andy@petdance.com, Apr 22, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.