git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/6] more automation for cover letter generation

From
FTFrank Terbeck <ft@bewatermyfriend.org>
Date
Apr 18, 2009, 16:16 UTC
Message-ID
<1240071381-25165-1-git-send-email-ft@bewatermyfriend.org>

I like cover letters, in fact I like them enough to always want --cover-letter to format-patch. The problem with that are patch "series" that are only one patch long, where a cover letter would feel silly.

For now, I solved that by using a shell function that wrapped around format-patch and did the trick for me.

With this series, format-patch can do it and do it better than my wrapper could.

The following setup would suit me pretty well:
[format]
    coverletter = true
    coveronepatch = false
    overwritecoverletter = false

The series is based on master and doesn't seem to break anything within the test suite. It could maybe use own tests, but I must admit that I didn't look too closely at how git's test suite works and where to put in tests for this.

Finally, this series does not change anything about format-patch's default behaviour.

Regards, Frank
Frank Terbeck (6):
  format-patch: add cover{letter,onepatch} options
    The above makes it possible to *always* create cover letters
    without requesting it via --cover-letter. You can also suppress
    cover letters for patch series, that are just one patch long,
    where you'd probably put anything you have to say in addition
    between '---' and the diffstat.
  Add documentation for format-patch's --cover-one-patch
  Document format.coverletter and format.coveronepatch
  format-patch: introduce overwritecoverletter option
    When you're always generating cover letters, it can be a good idea
    to not overwrite an existing cover letter, especially if you're
    just refreshing your patch series, or added more commits to it -
    were comments you may have made in an existing cover letter might
    be valuable for the new patch series as well. Therefore setting
    overwritecoverletter to false protects you from overwriting an
    existing cover letter.
    I had hoped that this change would be possible without changes in so
    many places, but I didn't see a straight forward one.
  Add documentation for --cover-overwrite
  Document format.overwritecoverletter
 Documentation/config.txt           |   15 +++++++++++++
 Documentation/git-format-patch.txt |   11 +++++++++
 builtin-log.c                      |   40 +++++++++++++++++++++++++++++++----
 log-tree.c                         |    9 +++++--
 log-tree.h                         |    4 +-
 5 files changed, 69 insertions(+), 10 deletions(-)
Next: Frank Terbeck
Message 1 of 21 in “more automation for cover letter generation”
  1. 0/6 more automation for cover letter generationFrank Terbeck, Apr 18, 2009
  2. 1/6 format-patch: add cover{letter,onepatch} optionsFrank Terbeck, Apr 18, 2009
  3. 2/6 Add documentation for format-patch's --cover-one-patchFrank Terbeck, Apr 18, 2009
  4. 3/6 Document format.coverletter and format.coveronepatchFrank Terbeck, Apr 18, 2009
  5. 4/6 format-patch: introduce overwritecoverletter optionFrank Terbeck, Apr 18, 2009
  6. 5/6 Add documentation for --cover-overwriteFrank Terbeck, Apr 18, 2009
  7. 6/6 Document format.overwritecoverletterFrank Terbeck, Apr 18, 2009
  8. Junio C HamanoApr 18, 2009
  9. 0/4 more automation for cover letter generationFrank Terbeck, May 4, 2009
  10. 1/4 Add format.coverletter optionFrank Terbeck, May 4, 2009
  11. 2/4 Add format.coverauto booleanFrank Terbeck, May 4, 2009
  12. Stephen BoydMay 4, 2009
  13. Frank TerbeckMay 4, 2009
  14. Junio C HamanoMay 4, 2009
  15. Frank TerbeckMay 5, 2009
  16. Junio C HamanoMay 5, 2009
  17. Frank TerbeckMay 5, 2009
  18. Frank TerbeckMay 5, 2009
  19. 3/4 Add tests for coverauto, coverletter and --cover-letterFrank Terbeck, May 4, 2009
  20. 4/4 Documentation for format.coverletter and --cover-letterFrank Terbeck, May 4, 2009
  21. Jeff KingApr 21, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.