git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[EGIT PATCH 1/4] Add actual test for success to ConnectOperationTest

From
Robin Rosenberg <robin.rosenberg@dewire.com>
Date
Apr 8, 2009, 15:51 UTC
Message-ID
<1239205891-28236-1-git-send-email-robin.rosenberg@dewire.com>
Also remove a few obsolete lines (irrelevant asserts)
Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>
---
 .../op/T0001_ConnectProviderOperationTest.java     |   16 +++-------------
 1 files changed, 3 insertions(+), 13 deletions(-)
diff --git a/org.spearce.egit.core.test/src/org/spearce/egit/core/op/T0001_ConnectProviderOperationTest.java b/org.spearce.egit.core.test/src/org/spearce/egit/core/op/T0001_ConnectProviderOperationTest.java
index 092c048..1d332a3 100644
--- a/org.spearce.egit.core.test/src/org/spearce/egit/core/op/T0001_ConnectProviderOperationTest.java
+++ b/org.spearce.egit.core.test/src/org/spearce/egit/core/op/T0001_ConnectProviderOperationTest.java
@@ -89,19 +89,6 @@ public void testNewUnsharedFile() throws CoreException, IOException,
 		lck.setNewObjectId(id);
 		assertEquals(RefUpdate.Result.NEW, lck.forceUpdate());
 
-		// helper asserts, this is not what we are really testing
-		assertTrue("blob missing", new File(gitDir,
-				"objects/2e/2439c32d01f0ef39644d561945e8f4b2239489").exists());
-
-		assertTrue("tree missing", new File(gitDir,
-				"objects/87/a105cc4bc0a79885d07ec560c3eee49438acf0").exists());
-		assertTrue("tree missing", new File(gitDir,
-				"objects/08/ccc3d91a14d337a45f355d3d63bd97fd5e4db9").exists());
-		assertTrue("tree missing", new File(gitDir,
-				"objects/9d/aeec817090098f05eeca858e3a552d78b0a346").exists());
-		assertTrue("commit missing", new File(gitDir,
-				"objects/09/6f1a84091b90b6d9fb12f95848da69496305c1").exists());
-
 		ConnectProviderOperation operation = new ConnectProviderOperation(
 				project.getProject(), null);
 		operation.run(null);
@@ -125,5 +112,8 @@ protected IStatus run(IProgressMonitor monitor) {
 			Thread.sleep(1000);
 		}
 		System.out.println("DONE");
+
+		assertNotNull(RepositoryProvider.getProvider(project.getProject()));
+
 	}
 }
-- 
1.6.2.2.446.gfbdc0
Next: Robin Rosenberg
Message 1 of 4 in “Add actual test for success to ConnectOperationTest”
  1. 1/4 Add actual test for success to ConnectOperationTestRobin Rosenberg, Apr 8, 2009
  2. 2/4 Add a method to RepositoryMapping to get the directory for not-yet-mapped projectsRobin Rosenberg, Apr 8, 2009
  3. 3/4 Use explicit bundle name in UIText to aid IDE integrationRobin Rosenberg, Apr 8, 2009
  4. 4/4 Multi-project connect to Git providerRobin Rosenberg, Apr 8, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.