git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/5] Header includes cleanup

From
NDNathaniel P Dawson <nathaniel.dawson@gmail.com>
Date
Mar 30, 2009, 09:55 UTC
Message-ID
<1238406925-15907-5-git-send-email-nathaniel.dawson@gmail.com>
In-Reply-To
<1238406925-15907-4-git-send-email-nathaniel.dawson@gmail.com>
Deleted header includes of object.h, tree.h, strbuf.h, and decorate.h where commit.h was included since commit.h includes them.
Signed-off-by: Nathaniel P Dawson <nathaniel.dawson@gmail.com>
---
 alloc.c                |    1 -
 builtin-receive-pack.c |    1 -
 builtin-reset.c        |    2 --
 builtin.h              |    2 --
 bundle.c               |    1 -
 fsck.c                 |    3 +--
 index-pack.c           |    1 -
 list-objects.c         |    1 -
 object.c               |    1 -
 read-cache.c           |    1 -
 revision.c             |    2 --
 server-info.c          |    1 -
 sha1_file.c            |    1 -
 sha1_name.c            |    1 -
 tag.c                  |    1 -
 tree.c                 |    3 +--
 upload-pack.c          |    1 -
 walker.c               |    1 -
 wt-status.c            |    3 +--
 19 files changed, 3 insertions(+), 25 deletions(-)
diff --git a/alloc.c b/alloc.c
index 5b3d4a2..af0dd88 100644
--- a/alloc.c
+++ b/alloc.c
@@ -11,7 +11,6 @@
  */
 #include "cache.h"
 #include "blob.h"
-#include "tree.h"
 #include "commit.h"
 #include "tag.h"
 
diff --git a/builtin-receive-pack.c b/builtin-receive-pack.c
index a970b39..e95aa41 100644
--- a/builtin-receive-pack.c
+++ b/builtin-receive-pack.c
@@ -5,7 +5,6 @@
 #include "run-command.h"
 #include "exec_cmd.h"
 #include "commit.h"
-#include "object.h"
 #include "remote.h"
 #include "transport.h"
 
diff --git a/builtin-reset.c b/builtin-reset.c
index c0cb915..d44c935 100644
--- a/builtin-reset.c
+++ b/builtin-reset.c
@@ -9,13 +9,11 @@
  */
 #include "cache.h"
 #include "tag.h"
-#include "object.h"
 #include "commit.h"
 #include "run-command.h"
 #include "refs.h"
 #include "diff.h"
 #include "diffcore.h"
-#include "tree.h"
 #include "branch.h"
 #include "parse-options.h"
 
diff --git a/builtin.h b/builtin.h
index 1495cf6..b9ef9fc 100644
--- a/builtin.h
+++ b/builtin.h
@@ -1,8 +1,6 @@
 #ifndef BUILTIN_H
 #define BUILTIN_H
 
-#include "git-compat-util.h"
-#include "strbuf.h"
 #include "cache.h"
 #include "commit.h"
 
diff --git a/bundle.c b/bundle.c
index d0dd818..14966f8 100644
--- a/bundle.c
+++ b/bundle.c
@@ -1,6 +1,5 @@
 #include "cache.h"
 #include "bundle.h"
-#include "object.h"
 #include "commit.h"
 #include "diff.h"
 #include "revision.h"
diff --git a/fsck.c b/fsck.c
index e903f6a..8cbb6aa 100644
--- a/fsck.c
+++ b/fsck.c
@@ -1,8 +1,7 @@
 #include "cache.h"
 #include "blob.h"
-#include "tree.h"
-#include "tree-walk.h"
 #include "commit.h"
+#include "tree-walk.h"
 #include "tag.h"
 #include "fsck.h"
 
diff --git a/index-pack.c b/index-pack.c
index 7546822..ac6fc84 100644
--- a/index-pack.c
+++ b/index-pack.c
@@ -5,7 +5,6 @@
 #include "blob.h"
 #include "commit.h"
 #include "tag.h"
-#include "tree.h"
 #include "progress.h"
 #include "fsck.h"
 #include "exec_cmd.h"
diff --git a/list-objects.c b/list-objects.c
index c8b8375..6446f81 100644
--- a/list-objects.c
+++ b/list-objects.c
@@ -1,7 +1,6 @@
 #include "cache.h"
 #include "tag.h"
 #include "commit.h"
-#include "tree.h"
 #include "blob.h"
 #include "diff.h"
 #include "tree-walk.h"
diff --git a/object.c b/object.c
index 380652f..83f786c 100644
--- a/object.c
+++ b/object.c
@@ -1,6 +1,5 @@
 #include "cache.h"
 #include "blob.h"
-#include "tree.h"
 #include "commit.h"
 #include "tag.h"
 
diff --git a/read-cache.c b/read-cache.c
index 3f58711..b50b02e 100644
--- a/read-cache.c
+++ b/read-cache.c
@@ -8,7 +8,6 @@
 #include "cache-tree.h"
 #include "refs.h"
 #include "dir.h"
-#include "tree.h"
 #include "commit.h"
 #include "diff.h"
 #include "diffcore.h"
diff --git a/revision.c b/revision.c
index f5771c7..827108d 100644
--- a/revision.c
+++ b/revision.c
@@ -1,7 +1,6 @@
 #include "cache.h"
 #include "tag.h"
 #include "blob.h"
-#include "tree.h"
 #include "commit.h"
 #include "diff.h"
 #include "refs.h"
@@ -10,7 +9,6 @@
 #include "grep.h"
 #include "reflog-walk.h"
 #include "patch-ids.h"
-#include "decorate.h"
 #include "log-tree.h"
 
 volatile show_early_output_fn_t show_early_output;
diff --git a/server-info.c b/server-info.c
index 66b0d9d..3d54c44 100644
--- a/server-info.c
+++ b/server-info.c
@@ -1,6 +1,5 @@
 #include "cache.h"
 #include "refs.h"
-#include "object.h"
 #include "commit.h"
 #include "tag.h"
 
diff --git a/sha1_file.c b/sha1_file.c
index 54972f9..77e6f54 100644
--- a/sha1_file.c
+++ b/sha1_file.c
@@ -12,7 +12,6 @@
 #include "blob.h"
 #include "commit.h"
 #include "tag.h"
-#include "tree.h"
 #include "refs.h"
 #include "pack-revindex.h"
 #include "sha1-lookup.h"
diff --git a/sha1_name.c b/sha1_name.c
index 2f75179..c98cd30 100644
--- a/sha1_name.c
+++ b/sha1_name.c
@@ -1,7 +1,6 @@
 #include "cache.h"
 #include "tag.h"
 #include "commit.h"
-#include "tree.h"
 #include "blob.h"
 #include "tree-walk.h"
 #include "refs.h"
diff --git a/tag.c b/tag.c
index 4470d2b..94e2903 100644
--- a/tag.c
+++ b/tag.c
@@ -1,7 +1,6 @@
 #include "cache.h"
 #include "tag.h"
 #include "commit.h"
-#include "tree.h"
 #include "blob.h"
 
 const char *tag_type = "tag";
diff --git a/tree.c b/tree.c
index 25d2e29..b9e427d 100644
--- a/tree.c
+++ b/tree.c
@@ -1,8 +1,7 @@
 #include "cache.h"
 #include "cache-tree.h"
-#include "tree.h"
-#include "blob.h"
 #include "commit.h"
+#include "blob.h"
 #include "tag.h"
 #include "tree-walk.h"
 
diff --git a/upload-pack.c b/upload-pack.c
index a49d872..9a91b14 100644
--- a/upload-pack.c
+++ b/upload-pack.c
@@ -3,7 +3,6 @@
 #include "pkt-line.h"
 #include "sideband.h"
 #include "tag.h"
-#include "object.h"
 #include "commit.h"
 #include "exec_cmd.h"
 #include "diff.h"
diff --git a/walker.c b/walker.c
index e57630e..67ddcf6 100644
--- a/walker.c
+++ b/walker.c
@@ -1,7 +1,6 @@
 #include "cache.h"
 #include "walker.h"
 #include "commit.h"
-#include "tree.h"
 #include "tree-walk.h"
 #include "tag.h"
 #include "blob.h"
diff --git a/wt-status.c b/wt-status.c
index 929b00f..125a4c4 100644
--- a/wt-status.c
+++ b/wt-status.c
@@ -1,9 +1,8 @@
 #include "cache.h"
 #include "wt-status.h"
 #include "color.h"
-#include "object.h"
-#include "dir.h"
 #include "commit.h"
+#include "dir.h"
 #include "diff.h"
 #include "revision.h"
 #include "diffcore.h"

-- 
1.6.1.3
Previous: Nathaniel P DawsonNext: Nathaniel P Dawson
Message 5 of 17 in “Header includes cleanup”
  1. 0/5 Header includes cleanupNathaniel P Dawson, Mar 30, 2009
  2. 1/5 Header includes cleanupNathaniel P Dawson, Mar 30, 2009
  3. 2/5 Header includes cleanupNathaniel P Dawson, Mar 30, 2009
  4. 3/5 Header includes cleanupNathaniel P Dawson, Mar 30, 2009
  5. 4/5 Header includes cleanupNathaniel P Dawson, Mar 30, 2009
  6. 5/5 Header includes cleanupNathaniel P Dawson, Mar 30, 2009
  7. Johannes SixtMar 30, 2009
  8. Nathaniel P DawsonMar 30, 2009
  9. Christian CouderMar 31, 2009
  10. Junio C HamanoMar 31, 2009
  11. Christian CouderApr 2, 2009
  12. Junio C HamanoApr 2, 2009
  13. Jeff KingApr 2, 2009
  14. Christian CouderApr 3, 2009
  15. Jeff KingApr 3, 2009
  16. Christian CouderApr 3, 2009
  17. Christian CouderMar 31, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.