git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Correct missing SP characters in grammar comment at top of fast-import.c

From
newren@gmail.com <newren@gmail.com>
Date
Mar 25, 2009, 21:22 UTC
Message-ID
<1238016133-13509-1-git-send-email-newren@gmail.com>
From: Elijah Newren <newren@gmail.com>
Signed-off-by: Elijah Newren <newren@gmail.com>
---

Some point after discovering this 'bug', I noticed that the documentation in Documentation/git-fast-import.txt was accurate, so I added a comment at the top of the file pointing people at that document, as I suspect it is more likely to be kept up to date. If my assumption is wrong, or would prefer different wording, I'm all ears.

 fast-import.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/fast-import.c b/fast-import.c
index beeac0d..db44da3 100644
--- a/fast-import.c
+++ b/fast-import.c
@@ -1,4 +1,5 @@
 /*
+(See Documentation/git-fast-import.txt for maintained documentation.)
 Format of STDIN stream:
 
   stream ::= cmd*;
@@ -18,8 +19,8 @@ Format of STDIN stream:
 
   new_commit ::= 'commit' sp ref_str lf
     mark?
-    ('author' sp name '<' email '>' when lf)?
-    'committer' sp name '<' email '>' when lf
+    ('author' sp name sp '<' email '>' sp when lf)?
+    'committer' sp name sp '<' email '>' sp when lf
     commit_msg
     ('from' sp (ref_str | hexsha1 | sha1exp_str | idnum) lf)?
     ('merge' sp (ref_str | hexsha1 | sha1exp_str | idnum) lf)*
@@ -43,7 +44,7 @@ Format of STDIN stream:
 
   new_tag ::= 'tag' sp tag_str lf
     'from' sp (ref_str | hexsha1 | sha1exp_str | idnum) lf
-    ('tagger' sp name '<' email '>' when lf)?
+    ('tagger' sp name sp '<' email '>' sp when lf)?
     tag_msg;
   tag_msg ::= data;
 
-- 
1.6.0.6
Next: Shawn O. Pearce
Message 1 of 2 in “Correct missing SP characters in grammar comment at top of fast-import.c”
  1. Correct missing SP characters in grammar comment at top of fast-import.cnewren@gmail.com, Mar 25, 2009
  2. Shawn O. PearceMar 25, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.