Re: git-svn woes
- From
Ben Walton <bwalton@artsci.utoronto.ca>
- Date
- Feb 27, 2009, 21:02 UTC
- Message-ID
- <1235768206-sup-2071@ntdws12.chass.utoronto.ca>
- In-Reply-To
- <alpine.LFD.2.00.0902271442270.5511@xanadu.home>
Excerpts from Nicolas Pitre's message of Fri Feb 27 15:37:16 -0500 2009:
Show 6 quoted lines
> |Use of uninitialized value $lc_author in concatenation (.) or string at /home/nico/libexec/git-core/git-svn line 964. > |Use of uninitialized value $lc_rev in concatenation (.) or string at /home/nico/libexec/git-core/git-svn line 965. > |Use of uninitialized value $t in gmtime at /home/nico/libexec/git-core/git-svn line 4743. > |Use of uninitialized value $t in numeric comparison (<=>) at /home/nico/libexec/git-core/git-svn line 4744. > |Use of uninitialized value $t in subtraction (-) at /home/nico/libexec/git-core/git-svn line 4745. > |Use of uninitialized value $t in localtime at /home/nico/libexec/git-core/git-svn line 4746.
All of the $t references are due to the patch I kicked in a few days back. $t is set to the first function argument, which in this case was passed as a null reference. Should $t default to time() in this circumstance? That would match the previous behaviour when localtime(shift) was used, although it may mask errors like this...?
If so, I'll submit a small patch for that asap.
As for why it's getting a null reference if it shouldn't be, I'll leave that for the people that know the svn part of this.
HTH. -Ben
-- Ben Walton Systems Programmer - CHASS University of Toronto C:416.407.5610 | W:416.978.4302 GPG Key Id: 8E89F6D2; Key Server: pgp.mit.edu Contact me to arrange for a CAcert assurance meeting.