Re: [PATCH 00/23] builtin-remote improvments

From: Jay Soffian <jaysoffian@gmail.com>
Date: Feb 24, 2009, 10:53 UTC
Message-ID: <1235472816-52420-1-git-send-email-jaysoffian@gmail.com>
In-Reply-To: <cover.1235461736.git.jaysoffian@gmail.com>

On Tue, Feb 24, 2009 at 4:50 AM, Jay Soffian <jaysoffian@gmail.com> wrote:

Show 27 quoted lines

> Jay Soffian (18):
>  builtin-clone: move locate_head() to remote.c so it can be re-used
>  builtin-remote: move duplicated cleanup code its own function
>  builtin-remote: teach show to display remote HEAD
>  builtin-remote: add set-head subcommand
>  builtin-remote: better handling of multiple remote HEADs
>
>  remote.c: make match_refs() copy src ref before assigning to peer_ref
>  remote.c: don't short-circuit match_refs() when error in match_explicit_refs()
>  refactor duplicated get_local_heads() to remote.c
>  refactor duplicated ref_newer() to remote.c
>  string-list: new for_each_string_list() function
>  builtin-remote: rename variable and eliminate redundant function call
>  builtin-remote: name remote_refs consistently
>  builtin-remote: remove unused code in get_ref_states
>  builtin-remote: fix two inconsistencies in the output of "show <remote>"
>  builtin-remote: make get_remote_ref_states() always populate states.tracked
>  builtin-remote: refactor get_remote_ref_states()
>  builtin-remote: new show output style
>  builtin-remote: new show output style for push refspecs
>
> Jeff King (5):
>  test scripts: refactor start_httpd helper
>  add basic http clone/fetch tests
>  refactor find_refs_by_name to accept const list
>  remote: refactor guess_remote_head
>  remote: use exact HEAD lookup if it is available

Argh. Looking at this again, it seems clear to me now that I should've put Jeff's series at the beginning, followed by my refactoring (6-10), followed by the rest of my patches, so that all the refactoring is early.

And I forgot that I'd done patch #5 (better handling of multiple remote HEADs) a few days after 1-4. As part of this re-roll I should've redone 1-4 to include #5's functionality.

I also noticed I'm passing an argument to get_head_names() that it never uses. But fixing that touches at least 3 of the patches.

All of this is my way of saying ignore what I've emailed tonight till I can clean it up a bit more.

I apologize to the list for the spam.

When I have the series really ready, would you prefer I setup a repo for you to pull from? I'm loath to spam the list with another 24 messages.

j.