git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] fix the installation path for html documentation

From
Michael J Gruber <git@drmicha.warpmail.net>
Date
Feb 10, 2009, 15:14 UTC
Message-ID
<1234278853-25452-1-git-send-email-git@drmicha.warpmail.net>

Since 026fa0d5ad9538ca76838070861531c037d7b9ba (Move computation of absolute paths from Makefile to runtime (in preparation for RUNTIME_PREFIX) the installation of html doc was broken: Documentation/Makefile does not know how to resolve relative dirs, which results in html doc being installed in $(git-build-root)/Documentation/share/doc/git-doc.

Fix this by not exporting htmldir from Makefile since this allows Documentation/Makefile to compute htmldir from prefix.

Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
---
An alternative would be to teach Documentation/Makefile to take the
relative htmldir and make it into an absolute path. But the approach I'm
taking with this patch as analogous to how mandir is handled, with the
same draw back. But all is well as long as the build monkey messes with
prefix only.
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 27b9569..862b96c 100644
--- a/Makefile
+++ b/Makefile
@@ -228,7 +228,7 @@ GITWEB_FAVICON = git-favicon.png
 GITWEB_SITE_HEADER =
 GITWEB_SITE_FOOTER =
 
-export prefix bindir sharedir htmldir sysconfdir
+export prefix bindir sharedir sysconfdir
 
 CC = gcc
 AR = ar
-- 
1.6.1.2.253.ga34a
Next: Johannes Sixt
Message 1 of 3 in “fix the installation path for html documentation”
  1. fix the installation path for html documentationMichael J Gruber, Feb 10, 2009
  2. Johannes SixtFeb 10, 2009
  3. Junio C HamanoFeb 11, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.