git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/3] git-gui: define correct GIT_DIR for gitk

From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date
Feb 9, 2009, 02:00 UTC
Message-ID
<1234144850-2903-4-git-send-email-giuseppe.bilotta@gmail.com>
In-Reply-To
<1234144850-2903-1-git-send-email-giuseppe.bilotta@gmail.com>

When invoking gitk, git-gui assumed that the worktree was the dirname of $_gitdir and that, by consequence, the git dir could be set to the tail of $_gitdir once we changed to the worktree root directory.

The assumption is no longer true since the previous commit introduced support for more generic worktree locations, so export a GIT_DIR environment variable set to the full, normalized path of $_gitdir instead.

Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
---
 git-gui/git-gui.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
index 94317c7..de3f29c 100755
--- a/git-gui/git-gui.sh
+++ b/git-gui/git-gui.sh
@@ -1908,7 +1908,7 @@ proc do_gitk {revs} {
 
 		set pwd [pwd]
 		cd $_gitworktree
-		set env(GIT_DIR) [file tail [gitdir]]
+		set env(GIT_DIR) [file normalize [gitdir]]
 
 		eval exec $cmd $revs &
 
-- 
1.6.2.rc0.173.g5e148
Previous: Shawn O. PearceNext: Shawn O. Pearce
Message 8 of 9 in “git-gui: generic and robust worktree/gitdir support”
  1. 0/3 git-gui: generic and robust worktree/gitdir supportGiuseppe Bilotta, Feb 9, 2009
  2. 1/3 git-gui: properly check for a bare repoGiuseppe Bilotta, Feb 9, 2009
  3. Shawn O. PearceFeb 18, 2009
  4. Giuseppe BilottaFeb 18, 2009
  5. Shawn O. PearceFeb 18, 2009
  6. 2/3 git-gui: use the actual worktreeGiuseppe Bilotta, Feb 9, 2009
  7. Shawn O. PearceFeb 18, 2009
  8. 3/3 git-gui: define correct GIT_DIR for gitkGiuseppe Bilotta, Feb 9, 2009
  9. Shawn O. PearceFeb 18, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.