git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH JGIT] Little performance optimization - replace the previous one

From
Yann Simon <yann.simon.fr@gmail.com>
Date
Jan 31, 2009, 14:19 UTC
Message-ID
<1233411566.7844.11.camel@localhost>
- avoid one if
- avoid to calculate 2 times the same value
Signed-off-by: Yann Simon <yann.simon.fr@gmail.com>
---
 .../src/org/spearce/jgit/lib/GitIndex.java         |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/GitIndex.java
b/org.spearce.jgit/src/org/spearce/jgit/lib/GitIndex.java
index 454b540..6eeccff 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/lib/GitIndex.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/GitIndex.java
@@ -411,11 +411,9 @@ Entry(ByteBuffer b) {
                 * @throws IOException
                 */
                public boolean update(File f) throws IOException {
-                       boolean modified = false;
                        long lm = f.lastModified() * 1000000L;
-                       if (mtime != lm)
-                               modified = true;
-                       mtime = f.lastModified() * 1000000L;
+                       boolean modified = mtime != lm;
+                       mtime = lm;
                        if (size != f.length())
                                modified = true;
                        if (config_filemode()) {
--
1.6.0.6
Message 1 of 1 in “Little performance optimization - replace the previous one”
  1. Little performance optimization - replace the previous oneYann Simon, Jan 31, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.