[PATCH 5/5] [squash] fsck: revert --quick to the default and introduce --medium

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 30, 2009, 11:05 UTC
Message-ID: <1233313517-24208-6-git-send-email-gitster@pobox.com>
In-Reply-To: <1233313517-24208-5-git-send-email-gitster@pobox.com>

(This commit log message is designed to replace the previous one when patch text is squashed into the previous one).

Traditionally, "git fsck" only checked loose objects and "git fsck --full" checked both loose and packed objects fully.

This introduces a new medium level of validation that checks loose objects and runs the quicker packfile validation introduced earlier (in other words, the individual objects in packfiles are not validated, but we still make sure that the packfiles themselves are sound and individual objects pass their own CRC checks when the pack has version 2 idx file).

I hoped that the new "medium" level to give a cursory look at the pack data would be acceptable as the default, but given the benchmark data, I think it is a bit too slow to be the default. So you pass --medium to trigger this new mode, instead of --full.

In my private git project repository (almost fully packed but with may dangling objects) on my AMD 64X2:

    $ /usr/bin/time ./git-fsck
    0.18user 0.02system 0:00.20elapsed 100%CPU (0avgtext+0avgdata 0maxresident)k
    0inputs+0outputs (0major+3205minor)pagefaults 0swaps

    $ /usr/bin/time ./git-fsck --medium
    68.61user 0.43system 1:09.06elapsed 99%CPU (0avgtext+0avgdata 0maxresident)k
    0inputs+0outputs (0major+116707minor)pagefaults 0swaps

    $ /usr/bin/time ./git-fsck --full
    90.36user 0.61system 1:31.00elapsed 99%CPU (0avgtext+0avgdata 0maxresident)k
    0inputs+0outputs (0major+169641minor)pagefaults 0swaps

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 builtin-fsck.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/builtin-fsck.c b/builtin-fsck.c
index 72bf33b..83faa98 100644
--- a/builtin-fsck.c
+++ b/builtin-fsck.c
@@ -20,7 +20,7 @@ static int show_tags;
 static int show_unreachable;
 static int include_reflogs = 1;
 static int check_full;
-static int check_quick;
+static int check_medium;
 static int check_strict;
 static int keep_cache_objects;
 static unsigned char head_sha1[20];
@@ -578,7 +578,7 @@ static struct option fsck_opts[] = {
 	OPT_BOOLEAN(0, "cache", &keep_cache_objects, "make index objects head nodes"),
 	OPT_BOOLEAN(0, "reflogs", &include_reflogs, "make reflogs head nodes (default)"),
 	OPT_BOOLEAN(0, "full", &check_full, "fully check packs"),
-	OPT_BOOLEAN(0, "quick", &check_quick, "only check loose objects"),
+	OPT_BOOLEAN(0, "medium", &check_medium, "also check packs"),
 	OPT_BOOLEAN(0, "strict", &check_strict, "enable more strict checking"),
 	OPT_BOOLEAN(0, "lost-found", &write_lost_and_found,
 				"write dangling objects in .git/lost-found"),
@@ -594,8 +594,8 @@ int cmd_fsck(int argc, const char **argv, const char *prefix)
 	errors_found = 0;
 
 	argc = parse_options(argc, argv, fsck_opts, fsck_usage, 0);
-	if (check_full && check_quick)
-		die("--full and --quick?  which one do you want?");
+	if (check_full && check_medium)
+		die("--full and --medium?  which one do you want?");
 
 	if (write_lost_and_found) {
 		check_full = 1;
@@ -614,7 +614,7 @@ int cmd_fsck(int argc, const char **argv, const char *prefix)
 		fsck_object_dir(namebuf);
 	}
 
-	if (!check_quick) {
+	if (check_full || check_medium) {
 		struct packed_git *p;
 
 		verify_pack_flag = check_full ? 0 : VERIFY_PACK_QUICK;

-- 
1.6.1.2.312.g5be3c