[PATCHv3] gitweb: make static files accessible with PATH_INFO
- From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
- Date
- Jan 27, 2009, 13:29 UTC
- Message-ID
- <1233062946-22395-1-git-send-email-giuseppe.bilotta@gmail.com>
When PATH_INFO is defined, static files such as the defalt CSS or the shortcut icon are not accessible beyond the summary page (e.g. in shortlog or commit view).
Fix this by adding a <base> tag pointing to the script base URL.
Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com> --- Of course, last time I forgot that the BASE href is supposed to be absolute. While Opera apparently has no problem with it being relative, other browsers such as Firefox are stricter about it.
gitweb/gitweb.perl | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 931db4f..411b1f6 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -2901,6 +2901,14 @@ sub git_header_html { <meta name="robots" content="index, nofollow"/> <title>$title</title> EOF +# the stylesheet, favicon etc urls won't work correctly with path_info unless we set the appropriate base URL + if ($ENV{'PATH_INFO'}) { + my $base = $my_url; + my $sname = $ENV{'SCRIPT_NAME'}; + $base =~ s,\Q$sname\E$,,; + $base .= "/"; + print "<base href=\"$base\"/>\n"; + } # print out each stylesheet that exist if (defined $stylesheet) { #provides backwards capability for those people who define style sheet in a config file
-- 1.5.6.5