git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Avoid spurious error messages on error mistakes.

From
Pierre Habouzit <madcoder@debian.org>
Date
Jan 12, 2009, 23:09 UTC
Message-ID
<1231801776-20724-1-git-send-email-madcoder@debian.org>
In-Reply-To
<20090112230228.GA28545@chistera.yi.org>

Prior to that, if the user chose "squash" as a first action, the stderr looked like:

    grep: /home/madcoder/dev/scm/git/.git/rebase-merge/done: No such file or directory
    Cannot 'squash' without a previous commit
Now the first line is gone.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
---
 git-rebase--interactive.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh
index c8b0861..8ed2244 100755
--- a/git-rebase--interactive.sh
+++ b/git-rebase--interactive.sh
@@ -349,7 +349,7 @@ do_next () {
 	squash|s)
 		comment_for_reflog squash
 
-		has_action "$DONE" ||
+		test -f "$DONE" && has_action "$DONE" ||
 			die "Cannot 'squash' without a previous commit"
 
 		mark_action_done
-- 
1.6.1.161.g5e07b.dirty
Previous: Adeodato SimóNext: Junio C Hamano
Message 4 of 5 in “rebase-merge/done: No such file or directory”
  1. jidanni@jidanni.orgJan 12, 2009
  2. Johannes SchindelinJan 12, 2009
  3. Adeodato SimóJan 12, 2009
  4. Avoid spurious error messages on error mistakes.Pierre Habouzit, Jan 12, 2009
  5. Junio C HamanoJan 13, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.