Re: [ANNOUNCE] git-cola 1.3.4

From: R. Tyler Ballance <tyler@slide.com>
Date: Dec 26, 2008, 08:44 UTC
Message-ID: <1230281078.14882.89.camel@starfruit>
In-Reply-To: <402731c90812252359r5b6b9420hcadbfa076f561feb@mail.gmail.com>

On Thu, 2008-12-25 at 23:59 -0800, David Aguilar wrote:

Show 10 quoted lines

> I'm on debian.  There's official debian packages these days that are
> making their way into both ubuntu and debian.
> 
> I'm probably doing something wrong since maybe pyuic4 isn't supposed
> to be called via subprocess.Popen()?  See the INSTALL file under
> 'build issues'.  Your pyuic4 is missing a shebang line at the top of
> the file.  I'm not sure if that's a packaging bug (openSUSE) or pyqt4
> bug.  debian's pyuic4 has a #!/bin/sh line at the top and thus doesn't
> have this issue.  I should probably change it so that it works either
> way...  i'll see if I can work around that.

Impressive call! Adding the shebang to pyuic4 solved the issue, but I'm as far in the dark as you are as to whose packaging domain this bug falls under.

So that issue is out of the way, here's the next one I figure I should pass your way :)

        
        tyler@starfruit:~/source/git/git> git cola
        Traceback (most recent call last):
          File "/usr/local/bin/git-cola", line 54, in <module>
            main()
          File "/usr/local/lib64/python2.6/site-packages/cola/main.py",
        line 114, in main
            view = View(app.activeWindow())
          File
        "/usr/local/lib64/python2.6/site-packages/cola/views/main.py",
        line 22, in __init__
            self.setupUi(self)
          File
        "/usr/local/lib64/python2.6/site-packages/cola/gui/main.py",
        line 183, in setupUi
            self.splitter.setSortingEnabled(__sortingEnabled)
        AttributeError: setSortingEnabled
        tyler@starfruit:~/source/git/git>

(Pdb) self.splitter <PyQt4.QtGui.QSplitter object at 0x9d88d0> (Pdb) [f for f in dir(self.splitter) if f.lower().find('sort') >= 0] [] (Pdb)

I went ahead and changed the following lines in cola/gui/main.py to get it up and running:

        
        181         item = QtGui.QTreeWidgetItem(self.status_tree)
        182         item = QtGui.QTreeWidgetItem(self.status_tree)
        183         #self.splitter.setSortingEnabled(__sortingEnabled)
        184         self.horizontalLayout_2.addWidget(self.splitter)
        185
        #self.centralwidget.setSortingEnabled(__sortingEnabled)
        186         main.setCentralWidget(self.centralwidget)

This whole set up is very confusing to me, it appears that those files (judging by your .gitignore) are being generated by the Qt4 .ui files, but how that translates into submitting a patch I haven't the faintest idea :)

I got something running at the very least I suppose :)

Cheers

-- 
-R. Tyler Ballance
Slide, Inc.