git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t9129: skip the last two tests if UTF-8 locale not available

From
Miklos Vajna <vmiklos@frugalware.org>
Date
Dec 23, 2008, 01:09 UTC
Message-ID
<1229994564-5153-1-git-send-email-vmiklos@frugalware.org>
In-Reply-To
<7vzliogcie.fsf@gitster.siamese.dyndns.org>
Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
---
On Mon, Dec 22, 2008 at 12:50:49PM -0800, Junio C Hamano <gitster@pobox.com> wrote:
> I think some tests play nicer than this one and skip tests that want
> UTF-8 locales; you may want to teach this script the same trick.
What about this?

Tesed on two Linux boxes (where I have / do not have UTF-8) and HP-UX (where I do not have, either).

 t/t9129-git-svn-i18n-commitencoding.sh |   30 +++++++++++++++++-------------
 1 files changed, 17 insertions(+), 13 deletions(-)
diff --git a/t/t9129-git-svn-i18n-commitencoding.sh b/t/t9129-git-svn-i18n-commitencoding.sh
index 938b7fe..8a9dde4 100755
--- a/t/t9129-git-svn-i18n-commitencoding.sh
+++ b/t/t9129-git-svn-i18n-commitencoding.sh
@@ -60,21 +60,25 @@ do
 	'
 done
 
-test_expect_success 'ISO-8859-1 should match UTF-8 in svn' '
-(
-	cd ISO-8859-1 &&
-	compare_svn_head_with "$TEST_DIRECTORY"/t3900/1-UTF-8.txt
-)
-'
-
-for H in EUCJP ISO-2022-JP
-do
-	test_expect_success '$H should match UTF-8 in svn' '
+if locale -a |grep -q en_US.utf8; then
+	test_expect_success 'ISO-8859-1 should match UTF-8 in svn' '
 	(
-		cd $H &&
-		compare_svn_head_with "$TEST_DIRECTORY"/t3900/2-UTF-8.txt
+		cd ISO-8859-1 &&
+		compare_svn_head_with "$TEST_DIRECTORY"/t3900/1-UTF-8.txt
 	)
 	'
-done
+
+	for H in EUCJP ISO-2022-JP
+	do
+		test_expect_success '$H should match UTF-8 in svn' '
+		(
+			cd $H &&
+			compare_svn_head_with "$TEST_DIRECTORY"/t3900/2-UTF-8.txt
+		)
+		'
+	done
+else
+	say "UTF-8 locale not available, test skipped"
+fi
 
 test_done
-- 
1.6.1.rc1.35.gae26e.dirty
Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 4 in “git 1.6.1-rc4 testing dependency”
  1. Peter van der DoesDec 22, 2008
  2. Junio C HamanoDec 22, 2008
  3. t9129: skip the last two tests if UTF-8 locale not availableMiklos Vajna, Dec 23, 2008
  4. Junio C HamanoDec 23, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.